Merge lp:~mdz/ubuntu/lucid/mountall/bug-557177 into lp:ubuntu/lucid/mountall

Proposed by Matt Zimmerman on 2010-04-08
Status: Rejected
Rejected by: James Westby on 2010-04-08
Proposed branch: lp:~mdz/ubuntu/lucid/mountall/bug-557177
Merge into: lp:ubuntu/lucid/mountall
Diff against target: 12 lines (+1/-1)
1 file modified
conf/mounted-tmp.conf (+1/-1)
To merge this branch: bzr merge lp:~mdz/ubuntu/lucid/mountall/bug-557177
Reviewer Review Type Date Requested Status
Scott James Remnant (Canonical) (community) 2010-04-08 Disapprove on 2010-04-08
Review via email: mp+23002@code.launchpad.net

Description of the change

One-liner to make mountall-tmp.conf fail safely

To post a comment you must log in.

I already committed a much better fix for this yesterday.

review: Disapprove
Matt Zimmerman (mdz) wrote :

On Thu, Apr 08, 2010 at 10:01:35AM -0000, Scott James Remnant wrote:
> Review: Disapprove
> I already committed a much better fix for this yesterday.

Oh, good. For some reason, this didn't end up linked to the bug, so I
didn't see it.

--
 - mdz

Unmerged revisions

297. By Matt Zimmerman on 2010-04-08

Make mounted-tmp.conf fail safe if MOUNTPOINT is unspecified (LP: #557177)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'conf/mounted-tmp.conf'
2--- conf/mounted-tmp.conf 2009-12-14 08:35:37 +0000
3+++ conf/mounted-tmp.conf 2010-04-08 08:33:34 +0000
4@@ -12,7 +12,7 @@
5 script
6 . /etc/default/rcS
7
8- cd "${MOUNTPOINT}"
9+ cd "${MOUNTPOINT:?mount point not specified}"
10 rm -f .X*-lock
11
12 case "${TMPTIME}" in

Subscribers

People subscribed via source and target branches

to all changes: