Merge ~mdeslaur/ubuntu-cve-tracker:check-cves-perf1 into ubuntu-cve-tracker:master
Status: | Merged |
---|---|
Merged at revision: | eb8e65266e3f7a038f589060a9dff7be4cd69e0c |
Proposed branch: | ~mdeslaur/ubuntu-cve-tracker:check-cves-perf1 |
Merge into: | ubuntu-cve-tracker:master |
Diff against target: |
82 lines (+17/-15) 1 file modified
scripts/check-cves (+17/-15) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Beattie | Approve | ||
Review via email: mp+462263@code.launchpad.net |
Commit message
commit cb191ce1d077e41
Author: Marc Deslauriers <email address hidden>
Date: Tue Mar 12 15:02:34 2024 -0400
check-cves: improve performance with sets instead of lists
CVEIgnoreNo
lists of CVEs and check-cves keeps searching for cves in them.
Switching them to sets dramatically improves performance.
commit bcc2a35fad29a1d
Author: Marc Deslauriers <email address hidden>
Date: Tue Mar 12 12:55:12 2024 -0400
check-cves: simplify mistriaged() logic
We don't need to call source_map.madison here and perform expensive
searches, we just need to know if we can see this package in the
source map. Bail out as soon as we do.
Description of the change
This merge proposal dramatically improves check-cves performance:
BEFORE:
$ time ./scripts/
real 3m17.930s
user 3m17.660s
sys 0m0.274s
AFTER:
$ time ./scripts/
real 0m5.845s
user 0m5.571s
sys 0m0.292s
Awesome catch, thanks! Merged.