Merge ~mdeslaur/ubuntu-cve-tracker:perf into ubuntu-cve-tracker:master

[Marc Deslauriers]

check-syntax: build up aliases cache once

Build up an aliases cache once, instead of performaing expensive
operations while processing each CVE. This dramatically reduces
the time required for check-syntax.

BEFORE:

$ time ./scripts/check-syntax -j8

real 3m12.768s
user 22m34.429s
sys 2m57.485s

AFTER:

$ time ./scripts/check-syntax -j8

real 2m22.853s
user 15m49.636s
sys 2m59.093s

[Steve Beattie (sbeattie)]

Nice, lgtm. Merged.

review: Approve

diff --git a/scripts/check-syntax b/scripts/check-syntax
index 5d476b0..b740331 100755
--- a/scripts/check-syntax
+++ b/scripts/check-syntax
@@ -130,15 +130,26 @@ def is_unpublished_kernel(kernel, release=None, debug=False):
             return True
     return False
 
-def get_pkgs_from_aliases(sources, aliases, pkg, rel):
+def build_aliases_cache(sources):
+    rev_aliases = {}
+
+    for rel in sources:
+        for pkg in sources[rel]:
+            if 'aliases' in sources[rel][pkg]:
+                for alias in sources[rel][pkg]['aliases']:
+                    if rel not in rev_aliases:
+                        rev_aliases[rel] = {}
+                    if alias not in rev_aliases[rel]:
+                        rev_aliases[rel][alias] = []
+                    rev_aliases[rel][alias].append(pkg)
+
+    return rev_aliases
+
+def get_pkgs_from_aliases(aliases, pkg, rel):
     if rel in aliases:
         if pkg in aliases[rel]:
             return aliases[rel][pkg]
-    else:
-        aliases[rel] = {}
-
-    aliases[rel][pkg] = source_map.get_aliases_of_ubuntu_package(sources, pkg, rel)
-    return aliases[rel][pkg]
+    return []
 
 def subprocess_setup():
     # Python installs a SIGPIPE handler by default. This is usually not what
@@ -405,7 +416,7 @@ if len(cna_cves_set) > 0 and all_files:
         print("%s: %d: %s that we assigned needs an UCT entry.\n"
               % (cna_cves_set[cve][0], cna_cves_set[cve][1], cve))
 
-aliases_cache = {}
+aliases_cache = build_aliases_cache(source)
 
 def fixup_entry(filename, pkg, rel):
     # If release is devel or EOL, we should add the proper status instead of removing
@@ -613,7 +624,7 @@ def check_cve(cve):
 
                 if not skip_aliases:
                     aliases = False
-                    pkgs_from_aliases = get_pkgs_from_aliases(source, aliases_cache, pkg, rel)
+                    pkgs_from_aliases = get_pkgs_from_aliases(aliases_cache, pkg, rel)
                     if pkgs_from_aliases:
                         aliases = True
                         aliases_releases.add(rel)