Merge lp:~mdeslaur/ubiquity/fix-random-seed into lp:ubiquity

[Marc Deslauriers]

  scripts/plugininstall.py: Write initial random seed to systemd
  location (LP: #1523199)

[Dimitri John Ledkov (xnox)]

As of 4.2 kernel there is no need for random seed. Thus systemd seed service will do nothing, and we shouldn't need to fix this in xenial.

Maybe this needs to be fixed in prior releases, i do not know.

http://lists.freedesktop.org/archives/systemd-devel/2015-June/033297.html

http://www.phoronix.com/scan.php?page=news_item&px=Linux-4.2-Crypto-Akcipher-PKE

http://marc.info/?l=linux-kernel&m=143496272614455&w=2

Thus why should we fix this?! I think we should like remove it completely.

review: Needs Information

[Marc Deslauriers (mdeslaur)]

The Jitter RNG linked above is for the Crypto API code, and isn't relevant for the random device.
The random device still needs to be seeded at boot.

[Mathieu Trudel-Lapierre (cyphermox)]

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2015-11-02 03:21:38 +0000
+++ debian/changelog	2015-12-09 13:25:54 +0000
@@ -1,3 +1,10 @@
+ubiquity (2.21.39) UNRELEASED; urgency=medium
+
+  * scripts/plugininstall.py: Write initial random seed to systemd
+    location (LP: #1523199)
+
+ -- Marc Deslauriers <[e-mail]>  Wed, 09 Dec 2015 08:17:25 -0500
+
 ubiquity (2.21.38) xenial; urgency=medium
 
   * d-i/sources.list: switch to xenial.

=== modified file 'scripts/plugininstall.py'
--- scripts/plugininstall.py	2015-11-02 03:19:11 +0000
+++ scripts/plugininstall.py	2015-12-09 13:25:54 +0000
@@ -1725,7 +1725,7 @@
             return
         if not stat.S_ISCHR(st.st_mode):
             return
-        if not os.path.isdir(self.target_file("var/lib/urandom")):
+        if not os.path.isdir(self.target_file("var/lib/systemd")):
             return
 
         poolbytes = 512
@@ -1740,7 +1740,7 @@
         old_umask = os.umask(0o077)
         try:
             with open("/dev/urandom", "rb") as urandom:
-                with open(self.target_file("var/lib/urandom/random-seed"),
+                with open(self.target_file("var/lib/systemd/random-seed"),
                           "wb") as seed:
                     seed.write(urandom.read(poolbytes))
         except IOError: