Code review comment for lp:~mdcallag/maria/5.3fcntl
Revision history for this message
| Michael Widenius (monty) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Hi!
>>>>> "Mark" == Mark Callaghan <email address hidden> writes:
Mark> Mark Callaghan has proposed merging lp:~mdcallag/maria/5.3fcntl into lp:maria.
Mark> Requested reviews:
Mark> Maria-captains (maria-captains)
Mark> For more details, see:
Mark> https:/
Mark> This changes mysqld to use socket timeouts rather than non-blocking, setsockopt, blocking, setsockopt. It reduces fcntl calls significantly. Many Linux kernels use the big kernel lock for fcntl and all threads can get stuck on it on a big multi-core server with 500+ concurrent connections.
Mark> With this change I double peak QPS on sysbench readonly (100k -> 200k).
Mark> The change differs from my original change in the Facebook patch. The original change broke rpl.rpl_ssl. I excluded two lines while porting.
I will look at this during this week. Thanks!
Regards,
Monty