Code review comment for lp:~mdavidsaver/epics-base/reorg-src

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

> Did you have any particular reason for putting antelope and flex under
> libCom/tools rather than directly under libCom? I'm currently inclined to
> drop the tools layer.

Because antelope and e_flex use epicsTempFile which is part of libCom. So currently they have a build dependency on libCom.

At the same time asLib.y needs antelope to generate the access security file parser. Now asLib is built as part of libCom.

Thus we have a circular dependency which I currently resolve by linking antelope with epicsTempFile.o instead of the full libCom. Then using antelope to generate asLib.c for inclusion in the final Com.so library. Given this rather tangled situation it seemed appropriate to put antelope/e_flex under the libCom directory.

If you dislike the situation I would suggest looking at removing the dependency of antelope/e_flex on epicsTempFile. This seems like the best way to break the dependency loop. I didn't do this initially because, in the interest of trying not to do too much at once, I avoided any substantial source code modification.

« Back to merge proposal