Merge lp:~mdaniel-k/mailmanweb/acceptable_aliases into lp:mailmanweb

Proposed by Daniel Mizyrycki
Status: Approved
Approved by: Florian Fuchs
Approved revision: 34
Proposed branch: lp:~mdaniel-k/mailmanweb/acceptable_aliases
Merge into: lp:mailmanweb
Diff against target: 25 lines (+5/-1)
2 files modified
setup.py (+2/-1)
src/mailmanweb/views.py (+3/-0)
To merge this branch: bzr merge lp:~mdaniel-k/mailmanweb/acceptable_aliases
Reviewer Review Type Date Requested Status
Florian Fuchs Approve
Review via email: mp+97760@code.launchpad.net

Description of the change

Properly display acceptable aliases

To post a comment you must log in.
Revision history for this message
Florian Fuchs (flo-fuchs) wrote :

Hi Daniel,

I added your changes to lp:postorius which is the official location now.

Thanks again!
Forian

review: Approve

Unmerged revisions

34. By Daniel Mizyrycki <daniel@seagull>

Properly display acceptable aliases.

33. By Daniel Mizyrycki <daniel@seagull>

Add dependency.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2012-03-12 18:32:09 +0000
3+++ setup.py 2012-03-15 22:00:27 +0000
4@@ -15,5 +15,6 @@
5 url = "https://code.launchpad.net/~flo-fuchs/mailmanwebgsoc2011/transition",
6 packages = find_packages('src'),
7 package_dir = {'': 'src'},
8- include_package_data = True
9+ include_package_data = True,
10+ install_requires = ['django-social-auth>=0.6.7']
11 )
12
13=== modified file 'src/mailmanweb/views.py'
14--- src/mailmanweb/views.py 2012-03-15 20:29:28 +0000
15+++ src/mailmanweb/views.py 2012-03-15 22:00:27 +0000
16@@ -371,6 +371,9 @@
17 for section in form.layout:
18 for option in section[1:]:
19 used_settings[option] = the_list.settings[option]
20+ # Hack to properly display the aliases
21+ if option == u'acceptable_aliases':
22+ used_settings[option] = '\n'.join(used_settings[option])
23 #recreate the form using the settings
24 form = ListSettings(visible_section,visible_option,data=used_settings)
25 form.truncate()

Subscribers

People subscribed via source and target branches