Merge lp:~mcintire-evan/ubuntu-terminal-app/toggle_keyboard into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Evan McIntire
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 144
Merged at revision: 147
Proposed branch: lp:~mcintire-evan/ubuntu-terminal-app/toggle_keyboard
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 104 lines (+28/-12)
4 files modified
po/com.ubuntu.terminal.pot (+7/-3)
src/app/qml/SettingsPage.qml (+8/-0)
src/app/qml/TerminalPage.qml (+11/-9)
src/app/qml/TerminalSettings.qml (+2/-0)
To merge this branch: bzr merge lp:~mcintire-evan/ubuntu-terminal-app/toggle_keyboard
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+281005@code.launchpad.net

Commit message

Added an option to toggle the visibility of the keyboard button.

Description of the change

Added an option to toggle the visibility of the keyboard button.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

This is great, thanks Evan!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/com.ubuntu.terminal.pot'
2--- po/com.ubuntu.terminal.pot 2015-08-09 14:03:25 +0000
3+++ po/com.ubuntu.terminal.pot 2015-12-19 05:16:44 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: \n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2015-08-09 16:01+0200\n"
9+"POT-Creation-Date: 2015-12-19 00:08-0500\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13@@ -161,11 +161,15 @@
14 msgid "Show Keyboard Bar"
15 msgstr ""
16
17-#: ../src/app/qml/SettingsPage.qml:52
18+#: ../src/app/qml/SettingsPage.qml:50
19+msgid "Show Keyboard Button"
20+msgstr ""
21+
22+#: ../src/app/qml/SettingsPage.qml:60
23 msgid "Font Size:"
24 msgstr ""
25
26-#: ../src/app/qml/SettingsPage.qml:85
27+#: ../src/app/qml/SettingsPage.qml:93
28 msgid "Color Scheme"
29 msgstr ""
30
31
32=== modified file 'src/app/qml/SettingsPage.qml'
33--- src/app/qml/SettingsPage.qml 2015-07-13 20:25:21 +0000
34+++ src/app/qml/SettingsPage.qml 2015-12-19 05:16:44 +0000
35@@ -46,6 +46,14 @@
36 }
37 }
38
39+ ListItem.Standard {
40+ text: i18n.tr("Show Keyboard Button")
41+ control: Switch {
42+ onCheckedChanged: settings.showKeyboardButton = checked;
43+ Component.onCompleted: checked = settings.showKeyboardButton;
44+ }
45+ }
46+
47 ListItem.Empty {
48 height: units.gu(10)
49 Label {
50
51=== modified file 'src/app/qml/TerminalPage.qml'
52--- src/app/qml/TerminalPage.qml 2015-07-13 20:25:21 +0000
53+++ src/app/qml/TerminalPage.qml 2015-12-19 05:16:44 +0000
54@@ -210,20 +210,22 @@
55 }
56 }
57
58- CircularTransparentButton {
59+ Loader {
60 id: keyboardButton
61-
62+ active: settings.showKeyboardButton
63 anchors {right: parent.right; margins: units.gu(1)}
64
65 y: parent.height - height - units.gu(1) - keyboardBarLoader.height
66
67- innerOpacity: 0.6
68- border {color: UbuntuColors.orange; width: units.dp(2)}
69- action: Action {
70- iconName: "input-keyboard-symbolic"
71- onTriggered: {
72- Qt.inputMethod.show();
73- terminal.forceActiveFocus();
74+ sourceComponent: CircularTransparentButton {
75+ innerOpacity: 0.6
76+ border {color: UbuntuColors.orange; width: units.dp(2)}
77+ action: Action {
78+ iconName: "input-keyboard-symbolic"
79+ onTriggered: {
80+ Qt.inputMethod.show();
81+ terminal.forceActiveFocus();
82+ }
83 }
84 }
85 }
86
87=== modified file 'src/app/qml/TerminalSettings.qml'
88--- src/app/qml/TerminalSettings.qml 2015-11-12 12:33:24 +0000
89+++ src/app/qml/TerminalSettings.qml 2015-12-19 05:16:44 +0000
90@@ -9,6 +9,7 @@
91 property alias fontStyle: innerSettings.fontStyle
92 property alias colorScheme: innerSettings.colorScheme
93 property alias showKeyboardBar: innerSettings.showKeyboardBar
94+ property alias showKeyboardButton: innerSettings.showKeyboardButton
95
96 readonly property int defaultFontSize: units.gu(0.4)
97 readonly property int minFontSize: 2
98@@ -39,6 +40,7 @@
99 property string fontStyle: "Ubuntu Mono"
100 property string colorScheme: "Ubuntu"
101 property bool showKeyboardBar: true
102+ property bool showKeyboardButton: true
103 property string jsonVisibleProfiles: "[]"
104 }
105

Subscribers

People subscribed via source and target branches