Merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Evan McIntire
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 145
Merged at revision: 146
Proposed branch: lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 24 lines (+6/-6)
1 file modified
src/app/qml/KeyboardRows/Layouts/FunctionKeys.json (+6/-6)
To merge this branch: bzr merge lp:~mcintire-evan/ubuntu-terminal-app/fix-function-keys
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+281461@code.launchpad.net

Commit message

Fix missing commit message.

Description of the change

F10 is listed twice in FunctionKeys.json, and F12 is not listed at all. This corrects that

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Thanks for the fix Evan!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/fix-function-keys/+merge/281461/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/26/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1426/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-autolanding/29/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1430/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/KeyboardRows/Layouts/FunctionKeys.json'
2--- src/app/qml/KeyboardRows/Layouts/FunctionKeys.json 2015-07-10 14:34:00 +0000
3+++ src/app/qml/KeyboardRows/Layouts/FunctionKeys.json 2016-01-02 06:29:24 +0000
4@@ -72,14 +72,14 @@
5 {
6 "main_action" : {
7 "type": "key",
8- "key" : "F10"
9- }
10- },
11- {
12- "main_action" : {
13- "type": "key",
14 "key" : "F11"
15 }
16+ },
17+ {
18+ "main_action" : {
19+ "type": "key",
20+ "key" : "F12"
21+ }
22 }
23 ]
24 }

Subscribers

People subscribed via source and target branches