Merge lp:~mcintire-evan/ubuntu-terminal-app/desktop-dimensions into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

[Evan McIntire]

Change the default dimensions so the terminal is a more proper size for desktops

Change the default dimensions so the terminal is a more proper size for desktops

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Works a treat, thanks Evan.

review: Approve

[David Planella (dpm)]

Thanks a lot Evan!

I think this effectively fixes the bug, but on a second iteration, I wonder whether we could have dynamic conversion of gu to column width/height, so that we could set the default width to e.g. 80 columns by 25 rows and it would result in the same column/row size on all displays.

[Evan McIntire (mcintire-evan)]

Thanks for the feedback!

I'd love to improve this with the suggestion you made, but I don't know what you're referring to (I'm fairly new to working with QML). I thought the point of the units.gu was to have the same size on all devices, as it would scale to match the pixel denisty and the like

If you could elaborate I'd love to know and improve this!

[Stefano Verzegnassi (verzegnassi-stefano)]

@Evan: yes, that's what units.gu's do.
What dpm says is that the terminal console should be 80 chars (width) x 24 chars (height).
That's the default/standard size of the VT100 terminal emulators.

That surely needs to be translated in terms of units.gu(), detecting the font size currently used by the terminal.

Seeing the bug report dpm opened earlier (lp:1539635) I guess the final result should be similar to:
    https://imgur.com/gXEjXQS

So that the app could be fully usable as a gnome-terminal replacement.

@Alan: IIRC, Filippo has discussed several times about the default terminal size, before he left the project. Is there any relevant observation he did?

[Alan Pope 🍺🐧🐱 🦄 (popey)]

I agree 80x25 (at whatever font size) is optimal for desktop initial size.

I don't recall anything specific about discussions we had about terminal size, but "do what other terminals do" seems to be the most sane way forward as it's familiar.

@stefano - is that a new tabbed UI I see there!? :) It looks amazing!

[Evan McIntire (mcintire-evan)]

@stefano, popey, thanks, I'll get right on that!

[Stefano Verzegnassi (verzegnassi-stefano)]

Yep, I agree.
Probably it's worth to provide a list of default modes too, as gnome-terminal does: 80x24, 80x43, 132x24 and 132x43.

@Alan: That's something I was playing on some week ago. I took that screenshot for a discussion I had with Niklas about the desktop UI. :)

[Jenkins Bot (ubuntu-core-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'src/app/qml/ubuntu-terminal-app.qml'
--- src/app/qml/ubuntu-terminal-app.qml	2016-01-22 18:29:56 +0000
+++ src/app/qml/ubuntu-terminal-app.qml	2016-01-29 02:29:53 +0000
@@ -12,8 +12,8 @@
     applicationName: "com.ubuntu.terminal"
     automaticOrientation: true
 
-    width: units.gu(50)
-    height: units.gu(75)
+    width: units.gu(90)
+    height: units.gu(55)
 
     AuthenticationService {
         onDenied: Qt.quit();