Merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
| Status: | Superseded |
|---|---|
| Proposed branch: | lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog |
| Merge into: | lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot |
| Diff against target: |
48 lines (+5/-5) 2 files modified
po/com.ubuntu.terminal.pot (+3/-3) src/app/qml/AuthenticationDialog.qml (+2/-2) |
| To merge this branch: | bzr merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alan Pope πΊπ§π± π¦ | 2015-12-16 | Approve on 2016-01-20 | |
| Nicholas Skaggs | Needs Fixing on 2016-01-19 | ||
| Jenkins Bot | continuous-integration | Needs Fixing on 2016-01-19 | |
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2016-01-20.
Commit Message
Changes authentication dialogue to "Enter passcode or passphrase" instead of "Enter password", to be more in line with other parts of the OS.
Description of the Change
Changes authentication dialogue to "Enter passcode or passphrase" instead of "Enter password", to be more in line with other parts of the OS
| Niklas Wenzel (nikwen) wrote : | # |
| Evan McIntire (mcintire-evan) wrote : | # |
Whoops, can't believe I made that mistake. Uploading a fix in a moment, thanks! :)
FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https:/
FAILED: Autolanding.
More details in the following jenkins job:
https:/
Executed test runs:
None: https:/
| Nicholas Skaggs (nskaggs) wrote : | # |
:-(
Text conflict in po/com.
1 conflicts encountered.
bzr: ERROR: Conflicts from merge
| Nicholas Skaggs (nskaggs) wrote : | # |
This needs to land after updating so pot file doesn't cause havoc again.
Unmerged revisions
- 144. By Evan McIntire on 2015-12-29
-
Fixed type ('passcore' -> 'passcode')
- 143. By Evan McIntire on 2015-12-16
-
Change Auth Dialog to be in line with other apps
("Enter Password" to "Enter Passcode or Passphrase")


Thank you for your contribution!
Please see my inline comment. If you fix it, we can happily merge this. ;)