Merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Evan McIntire on 2015-12-16
Status: Superseded
Proposed branch: lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 48 lines (+5/-5)
2 files modified
po/com.ubuntu.terminal.pot (+3/-3)
src/app/qml/AuthenticationDialog.qml (+2/-2)
To merge this branch: bzr merge lp:~mcintire-evan/ubuntu-terminal-app/change_auth_dialog
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ 2015-12-16 Approve on 2016-01-20
Nicholas Skaggs Needs Fixing on 2016-01-19
Jenkins Bot continuous-integration Needs Fixing on 2016-01-19
Review via email: mp+280781@code.launchpad.net

This proposal has been superseded by a proposal from 2016-01-20.

Commit Message

Changes authentication dialogue to "Enter passcode or passphrase" instead of "Enter password", to be more in line with other parts of the OS.

Description of the Change

Changes authentication dialogue to "Enter passcode or passphrase" instead of "Enter password", to be more in line with other parts of the OS

To post a comment you must log in.
Niklas Wenzel (nikwen) wrote :

Thank you for your contribution!

Please see my inline comment. If you fix it, we can happily merge this. ;)

Evan McIntire (mcintire-evan) wrote :

Whoops, can't believe I made that mistake. Uploading a fix in a moment, thanks! :)

Great! Thanks Evan.

review: Approve

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~mcintire-evan/ubuntu-terminal-app/change_auth_dialog/+merge/280781/+edit-commit-message

review: Needs Fixing (continuous-integration)

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/terminal-app-autolanding/9/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1461/console

review: Needs Fixing (continuous-integration)
Nicholas Skaggs (nskaggs) wrote :

:-(

Text conflict in po/com.ubuntu.terminal.pot
1 conflicts encountered.
bzr: ERROR: Conflicts from merge

review: Needs Fixing
Nicholas Skaggs (nskaggs) wrote :

This needs to land after updating so pot file doesn't cause havoc again.

Works! No typos! :D

review: Approve

Unmerged revisions

144. By Evan McIntire on 2015-12-29

Fixed type ('passcore' -> 'passcode')

143. By Evan McIntire on 2015-12-16

Change Auth Dialog to be in line with other apps
("Enter Password" to "Enter Passcode or Passphrase")

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/com.ubuntu.terminal.pot'
2--- po/com.ubuntu.terminal.pot 2015-08-09 14:03:25 +0000
3+++ po/com.ubuntu.terminal.pot 2015-12-29 23:24:02 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: \n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2015-08-09 16:01+0200\n"
9+"POT-Creation-Date: 2015-12-29 18:00-0500\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13@@ -34,11 +34,11 @@
14 msgstr ""
15
16 #: ../src/app/qml/AuthenticationDialog.qml:27
17-msgid "Enter password:"
18+msgid "Enter Passcode or Passphrase:"
19 msgstr ""
20
21 #: ../src/app/qml/AuthenticationDialog.qml:40
22-msgid "password"
23+msgid "passcode or passphrase"
24 msgstr ""
25
26 #: ../src/app/qml/AuthenticationDialog.qml:50
27
28=== modified file 'src/app/qml/AuthenticationDialog.qml'
29--- src/app/qml/AuthenticationDialog.qml 2015-07-13 20:25:21 +0000
30+++ src/app/qml/AuthenticationDialog.qml 2015-12-29 23:24:02 +0000
31@@ -24,7 +24,7 @@
32
33 title: i18n.tr("Authentication required")
34
35- text: i18n.tr("Enter password:")
36+ text: i18n.tr("Enter Passcode or Passphrase:")
37
38 signal passwordEntered(string password)
39 signal dialogCanceled
40@@ -37,7 +37,7 @@
41 id: passwordField
42 objectName: "inputField"
43
44- placeholderText: i18n.tr("password")
45+ placeholderText: i18n.tr("passcode or passphrase")
46 echoMode: TextInput.Password
47
48 onAccepted: okButton.clicked(text)

Subscribers

People subscribed via source and target branches