I've tested it on my BQ and it works fine! Good work!
However, giving a look at the code I saw there may be some complication in keeping this change working in future.
Mine just wants to be a suggestion on how to prevent this from happening, but I understand there may be some urgency in getting this patch landed and release a new version of terminal-app in the store. For that reason I'll abstain from doing a review.
Anyway, it's great to see new people joining the Core Apps team, so thank you! :)
P.S. I'd wait for Alan, David or Niklas to provide a review before doing any of the changes I suggested.
I've tested it on my BQ and it works fine! Good work!
However, giving a look at the code I saw there may be some complication in keeping this change working in future.
Mine just wants to be a suggestion on how to prevent this from happening, but I understand there may be some urgency in getting this patch landed and release a new version of terminal-app in the store. For that reason I'll abstain from doing a review.
Anyway, it's great to see new people joining the Core Apps team, so thank you! :)
P.S. I'd wait for Alan, David or Niklas to provide a review before doing any of the changes I suggested.