Merge lp:~mc-return/unity/unity.merge-fix1067534 into lp:unity

Proposed by MC Return on 2012-10-16
Status: Merged
Approved by: Brandon Schaefer on 2012-10-18
Approved revision: 2846
Merged at revision: 2857
Proposed branch: lp:~mc-return/unity/unity.merge-fix1067534
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/unityshell/unityshell.xml.in (+1/-1)
To merge this branch: bzr merge lp:~mc-return/unity/unity.merge-fix1067534
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing on 2012-10-17
Marco Trevisan (Treviño) Approve on 2012-10-17
Omer Akram (community) 2012-10-16 Approve on 2012-10-17
Review via email: mp+129999@code.launchpad.net

Commit Message

Unity actually provides the feature "fadetodesktop".
This change is needed to make unityshell just conflict with the Compiz "Fade to Desktop" (fadedesktop) plug-in, but work together with "Show Desktop" (showdesktop).
showdesktop only works if it is started after unityshell.

Description of the Change

Problem:
The default behaviour (before recent fixes) was loading the showdesktop plug-in before unityshell, which prevented it from working with Unity.
Currently it is prohibited to start this plug-in together with Unity (so it is either showdesktop or unityshell).

Solution:
We have to make sure that showdesktop is loaded after unityshell to allow the user to use it's functionality.
The fix should involve the possibility to enable this plug-in in CCSM together with Unity and to ensure that the plug-in is loaded after unityshell.

The "Fade to Desktop" plug-in provides essentially the same functionality like already provided by unityshell (fade to desktop), the only difference is that you can adjust the fade time with it.
Unfortunately this plug-in still makes some troubles, like a popping fade-out, so it will be best to not change current behaviour and prohibit the user using it together with Unity.

To post a comment you must log in.
Omer Akram (om26er) wrote :

this along with compiz fix worked.

review: Approve
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/unityshell.xml.in'
2--- plugins/unityshell/unityshell.xml.in 2012-10-16 01:12:16 +0000
3+++ plugins/unityshell/unityshell.xml.in 2012-10-16 22:27:25 +0000
4@@ -4,7 +4,7 @@
5 <_short>Ubuntu Unity Plugin</_short>
6 <_long>Plugin to draw the Unity Shell</_long>
7 <category>Desktop</category>
8- <feature>showdesktop</feature>
9+ <feature>fadetodesktop</feature>
10 <deps>
11 <relation type="after">
12 <plugin>bailer</plugin>