Merge lp:~mc-return/unity/unity.merge-fix-typos into lp:unity

Proposed by MC Return on 2012-07-09
Status: Superseded
Proposed branch: lp:~mc-return/unity/unity.merge-fix-typos
Merge into: lp:unity
Diff against target: 364 lines (+57/-57)
10 files modified
plugins/unityshell/src/nux-area-accessible.cpp (+23/-23)
plugins/unityshell/src/nux-area-accessible.h (+2/-2)
plugins/unityshell/src/nux-base-window-accessible.cpp (+5/-5)
plugins/unityshell/src/nux-layout-accessible.cpp (+1/-1)
plugins/unityshell/src/nux-object-accessible.cpp (+4/-4)
plugins/unityshell/src/nux-view-accessible.cpp (+3/-3)
plugins/unityshell/src/unitya11y.cpp (+14/-14)
plugins/unityshell/src/unitya11ytests.cpp (+1/-1)
plugins/unityshell/src/unityshell.cpp (+3/-3)
shortcuts/StandaloneShortcuts.cpp (+1/-1)
To merge this branch: bzr merge lp:~mc-return/unity/unity.merge-fix-typos
Reviewer Review Type Date Requested Status
Tim Penhey (community) 2012-07-09 Needs Fixing on 2012-07-23
Review via email: mp+113987@code.launchpad.net

This proposal has been superseded by a proposal from 2012-07-23.

Commit Message

Fixed several minor typos

Description of the Change

Fixes several minor typos

To post a comment you must log in.
2482. By MC Return on 2012-07-09

Fixed wording and typos

2483. By MC Return on 2012-07-09

Fixed more typos

2484. By MC Return on 2012-07-12

Rebased to latest lp:unity

Tim Penhey (thumper) wrote :

Thanks for this.

Just one point:

s/the objects destruction/the object's destruction/

review: Needs Fixing
2485. By MC Return on 2012-07-23

Rebased on latest lp:unity

2486. By MC Return on 2012-07-23

Fixed 'the objects destruction' -> 'the object's destruction' typo

2487. By MC Return on 2012-07-24

Fixed typo in all instances of UBUS_LAUNCHER_START_KEY_SWTICHER

2488. By MC Return on 2012-07-24

Rebased on latest lp:unity

2489. By MC Return on 2012-08-14

Hopefully fixed remaining UBUS_LAUNCHER_END_KEY_SWTICHER -> UBUS_LAUNCHER_END_KEY_SWITCHER typos

2490. By MC Return on 2012-08-15

Merged latest lp:unity

2491. By MC Return on 2012-08-17

Merged lp:unity

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/nux-area-accessible.cpp'
2--- plugins/unityshell/src/nux-area-accessible.cpp 2012-03-14 06:24:18 +0000
3+++ plugins/unityshell/src/nux-area-accessible.cpp 2012-07-23 08:18:21 +0000
4@@ -26,26 +26,26 @@
5 * nux::Area, exposing the common elements on each basic individual
6 * element (position, extents, etc)
7 *
8- * In this object is also implemented the main support for the focused
9- * object. This is complex due several reasons:
10- *
11- * * We need to ensure the proper order when the objects gets the focus
12- *
13- * * It doesn't make too sense to give the focus to an object that it
14- * is inside a inactive window, so it is also convenient to emit
15+ * In this object the main support for the focused object is also
16+ * implemented. This is complex due to several reasons:
17+ *
18+ * * We need to ensure the proper order when the objects get the focus
19+ *
20+ * * It doesn't make sense to give the focus to an object that is
21+ * inside an inactive window too, so it is also convenient to emit
22 * the window:active event before the focus change.
23 *
24- * => this is the reason there is implemented a system to delay the
25- * focus notification until the top level window became active
26+ * => this is the reason why there is a system to delay the focus
27+ * notification, until the top level window becomes active, implemented
28 *
29 * * But the main complexity comes from the fact that not all the
30- * objects on unity are implementing key nav in the same way.
31- *
32- * * Launcher uses exclusively InputArea methods like
33- * SetKeyboardFocus, OnStartKeyboardReceiver, etc. This is the
34- * key focus at a low level abstraction
35- *
36- * * Dash objects uses the events from Focusable. But in the same
37+ * objects of Unity are implementing key nav the same way.
38+ *
39+ * * The Launcher uses InputArea methods like
40+ * SetKeyboardFocus, OnStartKeyboardReceiver, etc exclusively.
41+ * This is the key focus at a low level abstraction
42+ *
43+ * * Dash objects use the events from Focusable. But in the same
44 * way, they require the low level key focus (OnStartFocus) and
45 * so on
46 *
47@@ -179,10 +179,10 @@
48 atk_component_add_focus_handler(ATK_COMPONENT(accessible),
49 nux_area_accessible_focus_handler);
50
51- /* NOTE: we can't search for the parent window on initilization as a
52- general rule, or we could enter on a infinite loop. At area this
53+ /* NOTE: we can't search for the parent window on initialization as a
54+ general rule, or we could enter an infinite loop. At area this
55 is done on the focus event. On the Switcher this is done on their
56- initialize itself */
57+ initialization itself */
58 }
59
60 static AtkObject*
61@@ -210,7 +210,7 @@
62 }
63
64 /*
65- * Checks if the parent actor, and his parent, etc is all visible
66+ * Checks if the parent actor, and his parent, etc are all visible
67 * Used to check the showing state
68 */
69 static gboolean
70@@ -349,7 +349,7 @@
71
72 //area = dynamic_cast<nux::Area*>(nux_object);
73
74- /* FIXME: SetFocused doesn't return if the force was succesful or
75+ /* FIXME: SetFocused doesn't return if the force was successful or
76 not, we suppose that this is the case like in cally and gail */
77
78 return TRUE;
79@@ -494,7 +494,7 @@
80 * This method checks if there is any pending notification, and emits
81 * it if it is possible
82 *
83- * Returns: TRUE if a atk notification was emitted, FALSE otherwise
84+ * Returns: TRUE if an atk notification was emitted, FALSE otherwise
85 */
86 gboolean
87 nux_area_accessible_check_pending_notification(NuxAreaAccessible* self)
88@@ -582,7 +582,7 @@
89 {
90 g_return_val_if_fail(NUX_IS_AREA_ACCESSIBLE(self), NULL);
91
92- /* Ensures that at least whe made a search for it */
93+ /* At least ensure that we made a search for it */
94 check_parent_window_connected(self);
95
96 return self->priv->parent_window;
97
98=== modified file 'plugins/unityshell/src/nux-area-accessible.h'
99--- plugins/unityshell/src/nux-area-accessible.h 2011-09-22 13:08:52 +0000
100+++ plugins/unityshell/src/nux-area-accessible.h 2012-07-23 08:18:21 +0000
101@@ -49,9 +49,9 @@
102 NuxObjectAccessibleClass parent_class;
103
104 /*
105- * Usually objects shouldn emit events like focus or selection
106+ * Usually objects shouldn't emit events like focus or selection
107 * changes until the toplevel window is active. This method is
108- * called when the toplevel window became active. Redefine it if you
109+ * called when the toplevel window becomes active. Redefine it if you
110 * need to check any pending state change notification.
111 */
112 gboolean(*check_pending_notification)(NuxAreaAccessible* self);
113
114=== modified file 'plugins/unityshell/src/nux-base-window-accessible.cpp'
115--- plugins/unityshell/src/nux-base-window-accessible.cpp 2011-09-22 18:54:58 +0000
116+++ plugins/unityshell/src/nux-base-window-accessible.cpp 2012-07-23 08:18:21 +0000
117@@ -26,11 +26,11 @@
118 * * Expose the child of BaseWindow (the layout)
119 * * Window event notification (activate, deactivate, and so on)
120 *
121- * BTW: we consider that one window is active if it has directly the
122- * keyboard focus, or if one of his child has the keyboard focus (ie:
123+ * BTW: we consider that one window is active, if it directly has
124+ * keyboard focus, or if one of its children has keyboard focus (ie:
125 * the Launcher via GrabKeyboardFocus)
126 *
127- * HasKeyboardFocus is not a reliable to check that:
128+ * HasKeyboardFocus is not reliable to check that:
129 * see bug https://bugs.launchpad.net/nux/+bug/745049
130 *
131 * So we need to update the state of the objects using the information
132@@ -147,7 +147,7 @@
133
134 atk_state_set_add_state(state_set, ATK_STATE_FOCUSABLE);
135
136- /* HasKeyboardFocus is not a reliable here:
137+ /* HasKeyboardFocus is not reliable here:
138 see bug https://bugs.launchpad.net/nux/+bug/745049 */
139 if (self->priv->active)
140 {
141@@ -162,7 +162,7 @@
142 static void
143 atk_window_interface_init(AtkWindowIface* iface)
144 {
145- /* AtkWindow just define signals at this moment */
146+ /* AtkWindow just defines signals at this moment */
147 }
148
149 /* public */
150
151=== modified file 'plugins/unityshell/src/nux-layout-accessible.cpp'
152--- plugins/unityshell/src/nux-layout-accessible.cpp 2011-08-01 17:08:48 +0000
153+++ plugins/unityshell/src/nux-layout-accessible.cpp 2012-07-23 08:18:21 +0000
154@@ -24,7 +24,7 @@
155 *
156 * #NuxLayoutAccessible implements the required ATK interfaces of
157 * nux::Layout, implementing the container related methods on
158- * AtkObject, in order to expose his objects
159+ * AtkObject, in order to expose its objects
160 *
161 */
162
163
164=== modified file 'plugins/unityshell/src/nux-object-accessible.cpp'
165--- plugins/unityshell/src/nux-object-accessible.cpp 2011-07-21 14:59:25 +0000
166+++ plugins/unityshell/src/nux-object-accessible.cpp 2012-07-23 08:18:21 +0000
167@@ -23,7 +23,7 @@
168 * @see_also: nux::Object
169 *
170 * #NuxObjectAccessible implements the required ATK interfaces of
171- * nux::Object, exposing the common elements on each basic individual
172+ * nux::Object, exposing the common elements of each basic individual
173 * element (position, extents, etc)
174 *
175 */
176@@ -129,11 +129,11 @@
177 /**
178 * nux_object_accessible_get_object:
179 *
180- * Returns the nux::Object this object is providing accessibility support.
181+ * Returns the nux::Object this object is providing accessibility support for.
182 *
183 * Note that there isn't a _set method. This is because setting that
184- * should only be done during initilization, and it doesn't make sense
185- * to change that during the life of the object.
186+ * should only be done during initialization, and it doesn't make sense
187+ * to change that during the lifetime of the object.
188 *
189 */
190 nux::Object*
191
192=== modified file 'plugins/unityshell/src/nux-view-accessible.cpp'
193--- plugins/unityshell/src/nux-view-accessible.cpp 2011-09-22 13:08:52 +0000
194+++ plugins/unityshell/src/nux-view-accessible.cpp 2012-07-23 08:18:21 +0000
195@@ -165,7 +165,7 @@
196 if (nux_object == NULL) /* defunct */
197 return state_set;
198
199- /* HasKeyboardFocus is not a reliable here:
200+ /* HasKeyboardFocus is not reliable here:
201 see bug https://bugs.launchpad.net/nux/+bug/745049 */
202 if (self->priv->key_focused)
203 atk_state_set_add_state(state_set, ATK_STATE_FOCUSED);
204@@ -262,7 +262,7 @@
205 {
206 self->priv->key_focused = focus_in;
207
208- /* we always led the focus notification to
209+ /* we always lead the focus notification to
210 _check_pending_notification, in order to allow the proper
211 window_activate -> focus_change order */
212 self->priv->pending_notification = TRUE;
213@@ -275,7 +275,7 @@
214 NuxViewAccessible* self = NULL;
215 nux::Object* nux_object = NULL;
216
217- /* We also call parent implementation, as we are not totally
218+ /* We also call the parent implementation, as we are not totally
219 overriding check_pending_notification, just adding extra
220 functionality*/
221 NUX_AREA_ACCESSIBLE_CLASS(nux_view_accessible_parent_class)->check_pending_notification(area_accessible);
222
223=== modified file 'plugins/unityshell/src/unitya11y.cpp'
224--- plugins/unityshell/src/unitya11y.cpp 2012-05-17 19:34:56 +0000
225+++ plugins/unityshell/src/unitya11y.cpp 2012-07-23 08:18:21 +0000
226@@ -82,7 +82,7 @@
227 g_type_class_unref(g_type_class_ref(UNITY_TYPE_UTIL_ACCESSIBLE));
228 }
229
230-/* This method is required because g_setting_new abort if the schema
231+/* This method is required because g_setting_new aborts if the schema
232 is not present. */
233 static gboolean
234 has_gsettings_schema(const gchar* schema)
235@@ -224,17 +224,17 @@
236
237 g_free(bridge_path);
238
239-// NOTE: we run manually the unit tests while developing by
240-// uncommenting this. Take a look to the explanation on
241+// NOTE: we run the unit tests manually while developing by
242+// uncommenting this. Take a look at the explanation in the
243 // unitya11ytests.h header for more information
244
245 // unity_run_a11y_unit_tests ();
246 }
247
248 /*
249- * Finalize the related issues related with the accessibility.
250+ * Finalize the issues related with accessibility.
251 *
252- * It mainly clean the resources related with the accessibility
253+ * It mainly cleans the resources related with accessibility
254 */
255 void
256 unity_a11y_finalize(void)
257@@ -259,9 +259,9 @@
258 * that would be add a ->get_accessible method on the nux::View
259 * subclasses itself.
260 *
261- * WARNING: as a reason the previous comment it is true. Take into
262- * account that you should be careful with the order you add those
263- * defines. The order will be from more specific classes to more
264+ * WARNING: as a reason the previous comment is true. Take into
265+ * account that you should be careful with the order in which you add
266+ * those defines. The order will be from more specific classes to more
267 * abstracted classes.
268 *
269 */
270@@ -327,7 +327,7 @@
271 AtkObject* accessible_object)
272 {
273 /* NOTE: the pair key:value (base_object:accessible_object) could be
274- already removed on on_accessible_destroy_cb. That just mean that
275+ already removed on on_accessible_destroy_cb. That just means that
276 g_hash_table_remove would return FALSE. We don't add a
277 debug/warning message to avoid being too verbose */
278
279@@ -339,7 +339,7 @@
280 GObject* where_the_object_was)
281 {
282 /* NOTE: the pair key:value (base_object:accessible_object) could be
283- already removed on on_object_destroy_cb. That just mean that
284+ already removed on on_object_destroy_cb. That just means that
285 g_hash_table_remove would return FALSE. We don't add a
286 debug/warning message to avoid being too verbose */
287
288@@ -350,9 +350,9 @@
289 * Returns the accessible object of a nux::View object
290 *
291 * This method tries to:
292- * * Check if area has already a accessibility object
293- * * If this is the case, returns that
294- * * If not, creates it and return the object
295+ * * Check if area already has a accessibility object
296+ * * If this is the case, return that
297+ * * If not, create it and return the object
298 *
299 * FIXME: this should be a temporal method. The best way to implement
300 * that would be add a ->get_accessible method on the nux::View
301@@ -379,7 +379,7 @@
302 g_hash_table_insert(accessible_table, object, accessible_object);
303
304 /* there are two reasons the object should be removed from the
305- * table: base object destroyed, or accessible object
306+ * table: base object destroyed or accessible object
307 * destroyed
308 */
309 g_object_weak_ref(G_OBJECT(accessible_object),
310
311=== modified file 'plugins/unityshell/src/unitya11ytests.cpp'
312--- plugins/unityshell/src/unitya11ytests.cpp 2012-07-12 19:01:51 +0000
313+++ plugins/unityshell/src/unitya11ytests.cpp 2012-07-23 08:18:21 +0000
314@@ -48,7 +48,7 @@
315 * This unit test checks if the destroy management is working:
316 *
317 * - If the state of a accessibility object is properly updated after
318- * the object destruction
319+ * the object's destruction
320 *
321 */
322 static gboolean
323
324=== modified file 'plugins/unityshell/src/unityshell.cpp'
325--- plugins/unityshell/src/unityshell.cpp 2012-07-16 11:28:24 +0000
326+++ plugins/unityshell/src/unityshell.cpp 2012-07-23 08:18:21 +0000
327@@ -344,13 +344,13 @@
328 ubus_manager_.RegisterInterest(UBUS_LAUNCHER_START_KEY_NAV,
329 sigc::mem_fun(this, &UnityScreen::OnLauncherStartKeyNav));
330
331- ubus_manager_.RegisterInterest(UBUS_LAUNCHER_START_KEY_SWTICHER,
332+ ubus_manager_.RegisterInterest(UBUS_LAUNCHER_START_KEY_SWITCHER,
333 sigc::mem_fun(this, &UnityScreen::OnLauncherStartKeyNav));
334
335 ubus_manager_.RegisterInterest(UBUS_LAUNCHER_END_KEY_NAV,
336 sigc::mem_fun(this, &UnityScreen::OnLauncherEndKeyNav));
337
338- ubus_manager_.RegisterInterest(UBUS_LAUNCHER_END_KEY_SWTICHER,
339+ ubus_manager_.RegisterInterest(UBUS_LAUNCHER_END_KEY_SWITCHER,
340 sigc::mem_fun(this, &UnityScreen::OnLauncherEndKeyNav));
341
342 ubus_manager_.RegisterInterest(UBUS_SWITCHER_START,
343@@ -2319,7 +2319,7 @@
344 auto id = value->id();
345
346 // iterate loop by hand rather than use std::find as this is considerably faster
347- // we care about performance here becuase of the high frequency in which this function is
348+ // we care about performance here because of the high frequency in which this function is
349 // called (nearly every frame)
350 unsigned int size = xwns.size();
351 for (unsigned int i = 0; i < size; ++i)
352
353=== modified file 'shortcuts/StandaloneShortcuts.cpp'
354--- shortcuts/StandaloneShortcuts.cpp 2012-05-07 22:28:17 +0000
355+++ shortcuts/StandaloneShortcuts.cpp 2012-07-23 08:18:21 +0000
356@@ -65,7 +65,7 @@
357 hints.push_back(std::shared_ptr<shortcut::AbstractHint>(new shortcut::MockHint(_("Switching"), "", "", _("Switch between applications."), shortcut::COMPIZ_KEY_OPTION, "unityshell", "alt_tab_forward")));
358 hints.push_back(std::shared_ptr<shortcut::AbstractHint>(new shortcut::MockHint(_("Switching"), "", "", _("Switch windows of current application."), shortcut::COMPIZ_KEY_OPTION, "unityshell", "alt_tab_next_window")));
359 hints.push_back(std::shared_ptr<shortcut::AbstractHint>(new shortcut::MockHint(_("Switching"), "", "", _("Close window switch, return to app switch."), shortcut::COMPIZ_KEY_OPTION, "unityshell", "alt_tab_detail_stop")));
360- hints.push_back(std::shared_ptr<shortcut::AbstractHint>(new shortcut::MockHint(_("Switching"), "", "", _("Moves the foucs."), shortcut::HARDCODED_OPTION, _("Cursor Left & Right"))));
361+ hints.push_back(std::shared_ptr<shortcut::AbstractHint>(new shortcut::MockHint(_("Switching"), "", "", _("Moves the focus."), shortcut::HARDCODED_OPTION, _("Cursor Left & Right"))));
362
363 // Workspaces
364 hints.push_back(std::shared_ptr<shortcut::AbstractHint>(new shortcut::MockHint(_("Workspaces"), "", "", _("Spread workspaces."), shortcut::COMPIZ_KEY_OPTION, "expo", "expo_key")));