Merge lp:~mc-return/unity/unity.merge-fix-member-variables-not-initialized-in-their-constructors into lp:unity

[MC Return]

Initialized class member variables in their respective constructors.
Used false for bools, 0 for ints and object pointers like SnDisplay* or SnMonitorContext*.

[Thomi Richards (thomir-deactivatedaccount)]

review: Approve

[Brandon Schaefer (brandontschaefer)]

Looks good to me. +1

review: Approve

=== modified file 'plugins/unityshell/src/StartupNotifyService.cpp'
--- plugins/unityshell/src/StartupNotifyService.cpp	2011-07-21 14:59:25 +0000
+++ plugins/unityshell/src/StartupNotifyService.cpp	2012-11-15 20:06:21 +0000
@@ -32,6 +32,8 @@
 }
 
 StartupNotifyService::StartupNotifyService()
+  : _sn_display(0)
+  , _sn_monitor(0)
 {
 }
 

=== modified file 'plugins/unityshell/src/UnityShowdesktopHandler.cpp'
--- plugins/unityshell/src/UnityShowdesktopHandler.cpp	2012-11-06 18:19:09 +0000
+++ plugins/unityshell/src/UnityShowdesktopHandler.cpp	2012-11-15 20:06:21 +0000
@@ -79,12 +79,13 @@
   return inhibiting_xid;
 }
 
-ShowdesktopHandler::ShowdesktopHandler (ShowdesktopHandlerWindowInterface *wi, compiz::WindowInputRemoverLockAcquireInterface *lock_acquire_interface) :
-  showdesktop_handler_window_interface_ (wi),
-  lock_acquire_interface_ (lock_acquire_interface),
-  remover_(),
-  state_ (StateVisible),
-  progress_ (0.0f)
+ShowdesktopHandler::ShowdesktopHandler (ShowdesktopHandlerWindowInterface *wi, compiz::WindowInputRemoverLockAcquireInterface *lock_acquire_interface)
+  : showdesktop_handler_window_interface_(wi)
+  , lock_acquire_interface_(lock_acquire_interface)
+  , remover_()
+  , state_(StateVisible)
+  , progress_(0.0f)
+  , was_hidden_(false)
 {
 }
 

=== modified file 'unity-shared/IconRenderer.cpp'
--- unity-shared/IconRenderer.cpp	2012-11-06 18:19:09 +0000
+++ unity-shared/IconRenderer.cpp	2012-11-15 20:06:21 +0000
@@ -220,6 +220,9 @@
 }
 
 IconRenderer::IconRenderer()
+  : icon_size(0)
+  , image_size(0)
+  , spacing(0)
 {
   pip_style = OUTSIDE_TILE;