Compiz

Merge lp:~mc-return/compiz/compiz.merge-fix347390-compiz-cannot-resize-vertically-AND-horizontally-with-keys into lp:compiz/0.9.11

  1. compiz.merge-fix347390-compiz-cannot-resize-vertically-AND-horizontally-with-keys
  2. Merge into 0.9.11
Proposed by MC Return
Status: Rejected
Rejected by: Christopher Townsend
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix347390-compiz-cannot-resize-vertically-AND-horizontally-with-keys
Merge into: lp:compiz/0.9.11
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/resize/src/logic/src/resize-logic.cpp (+1/-1)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix347390-compiz-cannot-resize-vertically-AND-horizontally-with-keys
Reviewer Review Type Date Requested Status
Christopher Townsend Disapprove
MC Return Needs Information
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+176725@code.launchpad.net

Commit message

Fixed keyboard resizing just working for either horizontal or vertical
resizing.

(Credits and thanks for this patch, Matija Skala <email address hidden>)

Description of the change

Note:
It does not work here...

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) :
review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3769
http://jenkins.qa.ubuntu.com/job/compiz-ci/278/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-saucy-amd64-ci/91
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-saucy-armhf-ci/91
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-saucy-i386-ci/91

Click here to trigger a rebuild:
http://s-jenkins:8080/job/compiz-ci/278/rebuild

review: Approve (continuous-integration)
Revision history for this message
MC Return (mc-return) wrote :

This needs information from the original author.
Let us see if he comments on it, otherwise we might have to reject it.

review: Needs Information
Revision history for this message
Christopher Townsend (townsend) wrote :

I took a look at this and although it makes the keyboard resizing a little better, it still doesn't work correctly.

As this has been sitting here for some time now with no action after MC Return's review, I'm just going to reject this. However, I'm taking a look at this and seeing how much work it will be to fix it.

review: Disapprove

Unmerged revisions

3769. By Matija Skala

Fixed keyboard resizing just working for either horizontal or vertical
resizing

(Credits and thanks for this patch, Matija Skala <email address hidden>)

(LP: #347390) !!!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/resize/src/logic/src/resize-logic.cpp'
2--- plugins/resize/src/logic/src/resize-logic.cpp 2013-05-12 09:39:45 +0000
3+++ plugins/resize/src/logic/src/resize-logic.cpp 2013-07-24 16:08:37 +0000
4@@ -409,7 +409,7 @@
5
6 mScreen->warpPointer (x - pointerX, y - pointerY);
7
8- mask = rKeys[i].resizeMask;
9+ mask |= rKeys[i].resizeMask;
10
11 mScreen->updateGrab (grabIndex, cursor[i]);
12 }

Subscribers

People subscribed via source and target branches

to all changes: