lp:~mc-return/compiz/compiz.merge-fix1182794-screenshot-not-compatible-with-unityshell.0

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:compiz/0.9.10

Sam Spilsbury: Approve on 2013-05-22

PS Jenkins bot: Pending (continuous-integration) requested 2013-05-22

Diff: 64 lines (+2/-13)

2 files modified

plugins/screenshot/src/screenshot.cpp (+2/-12)
plugins/screenshot/src/screenshot.h (+0/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1182794: Screenshot plugin + unityshell: Screenshot selection rectangle disappears when mouse stops moving

Medium

In Progress

Link a bug report

Related blueprints

3723. By MC Return on 2013-05-22

Reduced the .diff to make review easier

3722. By MC Return on 2013-05-22

Screenshot plugin:
We have to redraw and damage the painted region the whole time,
if unityshell is enabled, not only when it's size changed
Otherwise the constant whole-screen damaging of Unity makes the
screenshot selection box disappear

Note:
Screenshot is less efficient now, so this should probably be
reverted, once unityshell has learned to correctly damage just
repainted regions

(LP: #1182794)

3721. By Sami Jaktholm on 2013-05-21

Fade: Fix a typo that causes fade to constantly damage windows with a modified
      saturation. Fixes: https://bugs.launchpad.net/bugs/1159054.

Approved by PS Jenkins bot, Stephen M. Webb, MC Return.

3720. By MC Return on 2013-05-20

Cube code cleanup:

Replaced 0xffff with GLfloat MaxUShortFloat = static_cast <GLfloat>
(std::numeric_limits <unsigned short>::max ());.
Use prefix instead of postfix de- and increments.
Declaration and assignment of variables in one line.
Declare variables shortly before you need them.
Merged if condition checks.
Added missing breaks (just a style issue).
Added and removed brackets.
Added and removed newlines.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3719. By MC Return on 2013-05-20

Commands, minor code cleanup:

Declaration and assignment of variables in one line.
Return ASAP.
Added and removed newlines.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3718. By MC Return on 2013-05-18

ccp code cleanup:

Declare variables if you need them, do not declare them if you return.
Declare CCSSettingValue *val; outside the foreach loop.
Use prefix instead of postfix increments.
Merged if condition checks.
Declaration and assignment of variables in one line.
Removed redundant brackets.
Added and removed newlines.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3717. By MC Return on 2013-05-18

Text plugin code cleanup:

Do not declare variables you do not need if you return anyway.
Use prefix instead of postfix increments.
Merged if condition checks.
Declaration and assignment of variables in one line.
Added and removed newlines.
Removed redundant brackets.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3716. By Sami Jaktholm on 2013-05-18

Grid: Check that composite and opengl ABIs are COMPIZ_COMPOSITE_ABI and
      COMPIZ_OPENGL_ABI instead of CORE_ABIVERSION. Fixes: https://bugs.launchpad.net/bugs/1181461.

Approved by PS Jenkins bot, Sam Spilsbury.

3715. By MC Return on 2013-05-17

Titleinfo, minor code cleanup:

Declaration and assignment of local variables in one line.
Removed redundant brackets.
Added and removed newlines.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3714. By MC Return on 2013-05-17

Annotate plugin, code cleanup:

Use prefix instead of postfix increment.
Declaration and assignment of local variables in one line.
Removed redundant brackets.
Added and removed newlines if appropriate.
Fixed indentation.

Annotate plugin, fixes:

Use GL_LINE_LOOP to draw the rectangle outline as glRecti is not supported on GLES.
Simplified the coordinate calculation as the offset is not really needed here.

Approved by PS Jenkins bot, Sam Spilsbury.