Merge lp:~mc-return/compiz/compiz.merge-fix1179183-expo-inactive-viewports-saturation-setting-is-ignored into lp:compiz/0.9.10

Proposed by MC Return
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3698
Merged at revision: 3699
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix1179183-expo-inactive-viewports-saturation-setting-is-ignored
Merge into: lp:compiz/0.9.10
Diff against target: 19 lines (+6/-0)
1 file modified
plugins/expo/src/expo.cpp (+6/-0)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix1179183-expo-inactive-viewports-saturation-setting-is-ignored
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
Review via email: mp+163585@code.launchpad.net

Commit message

Expo plugin:
Fixed inactive viewports saturation setting being ignored.
Let's "fade to grey"... :)

(LP: #1179183)

Description of the change

Note:
Expo still misses a cleanup.
For the sake of easy reviewability this MP contains just the fix for bug #1179183.
A general cleanup of Expo will follow soonish...

Note 2:
As requested here: https://code.launchpad.net/~mc-return/compiz/compiz.merge-fix1178965-expo-redundant-configuration-changes/+merge/163434/comments/361091 :)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/expo/src/expo.cpp'
2--- plugins/expo/src/expo.cpp 2013-05-09 13:43:07 +0000
3+++ plugins/expo/src/expo.cpp 2013-05-13 18:11:33 +0000
4@@ -1214,9 +1214,15 @@
5 mask |= PAINT_SCREEN_CLEAR_MASK;
6
7 if (optionGetExpoAnimation () == ExpoScreen::ExpoAnimationZoom)
8+ {
9 vpBrightness = 0.0f;
10+ vpSaturation = 0.0f;
11+ }
12 else
13+ {
14 vpBrightness = (1.0f - sigmoidProgress (expoCam));
15+ vpSaturation = (1.0f - sigmoidProgress (expoCam));
16+ }
17
18 if (expoCam <= 0 || (expoCam > 0.0 && expoCam < 1.0 &&
19 optionGetExpoAnimation () != ExpoAnimationZoom))

Subscribers

People subscribed via source and target branches

to all changes: