Merge lp:~mc-return/compiz/compiz.merge-fix1134251-minor-issues into lp:compiz/0.9.9

Proposed by MC Return
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3626
Merged at revision: 3628
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix1134251-minor-issues
Merge into: lp:compiz/0.9.9
Diff against target: 728 lines (+60/-61)
50 files modified
CMakeLists.txt (+1/-1)
compizconfig/compizconfig-python/CMakeLists.txt (+1/-1)
compizconfig/libcompizconfig/src/compiz.cpp (+1/-2)
compizconfig/tests/compizconfig_ccs_setting_value_operators.cpp (+2/-2)
plugins/animation/src/animation.cpp (+1/-1)
plugins/animation/src/curvedfold.cpp (+1/-1)
plugins/animation/src/dodge.cpp (+1/-1)
plugins/animation/src/dream.cpp (+1/-1)
plugins/animation/src/extensionplugin.cpp (+1/-1)
plugins/animation/src/fade.cpp (+1/-1)
plugins/animation/src/focusfade.cpp (+1/-1)
plugins/animation/src/glide.cpp (+1/-1)
plugins/animation/src/grid.cpp (+1/-1)
plugins/animation/src/horizontalfold.cpp (+1/-1)
plugins/animation/src/magiclamp.cpp (+1/-1)
plugins/animation/src/options.cpp (+1/-1)
plugins/animation/src/restack.cpp (+1/-1)
plugins/animation/src/rollup.cpp (+1/-1)
plugins/animation/src/wave.cpp (+1/-1)
plugins/animation/src/zoomside.cpp (+1/-1)
plugins/animationaddon/src/airplane.cpp (+1/-1)
plugins/animationaddon/src/animationaddon.cpp (+1/-1)
plugins/animationaddon/src/beamup.cpp (+1/-1)
plugins/animationaddon/src/burn.cpp (+1/-1)
plugins/animationaddon/src/domino.cpp (+1/-1)
plugins/animationaddon/src/explode.cpp (+1/-1)
plugins/animationaddon/src/fold.cpp (+1/-1)
plugins/animationaddon/src/glide3.cpp (+1/-1)
plugins/animationaddon/src/leafspread.cpp (+1/-1)
plugins/animationaddon/src/particle.cpp (+1/-1)
plugins/animationaddon/src/polygon.cpp (+1/-1)
plugins/animationaddon/src/skewer.cpp (+1/-1)
plugins/bench/src/bench.cpp (+1/-1)
plugins/cubeaddon/src/cubeaddon.cpp (+1/-3)
plugins/expo/src/expo.cpp (+1/-1)
plugins/firepaint/src/firepaint.cpp (+1/-1)
plugins/group/src/group.h (+9/-9)
plugins/imgjpeg/src/imgjpeg.cpp (+2/-0)
plugins/mag/src/mag.cpp (+1/-1)
plugins/mousepoll/src/mousepoll.cpp (+1/-1)
plugins/resizeinfo/src/resizeinfo.cpp (+1/-1)
plugins/scalefilter/src/scalefilter.cpp (+1/-1)
plugins/session/src/session.cpp (+1/-1)
plugins/text/src/text.cpp (+1/-1)
plugins/trip/src/trip.cpp (+1/-1)
plugins/wall/src/offset_movement/src/offset-movement.cpp (+1/-1)
plugins/widget/src/widget.cpp (+1/-1)
src/pluginclasshandler/include/core/pluginclasshandler.h (+1/-1)
src/timer/tests/set-values/src/test-timer-set-values.cpp (+1/-1)
tests/system/xorg-gtest/tests/compiz_xorg_gtest_test_window_stacking.cpp (+1/-1)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix1134251-minor-issues
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+150768@code.launchpad.net

Commit message

Fixed minor cppcheck issues:

Do not assign a value to rv, because this value is never used.
Instead declare and assign a value to bool rv in the same line.

Do not assign false to Bool readonly, because this value is never used.
Instead declare the variable and assign a value in the same line.

Other minor problems:

Fixed some guaruntee->guarantee typos in comments.
Fixed copyright headers still referring to the old .c files.
Fixed wrong names in copyright headers.

(LP: #1134251)

Description of the change

cppcheck reports these valid issues:

[plugins/cubeaddon/src/cubeaddon.cpp:320] -> [plugins/cubeaddon/src/cubeaddon.cpp:322]: (performance) Variable 'rv' is reassigned a value before the old one has been used.

[compizconfig/libcompizconfig/src/compiz.cpp:731] -> [compizconfig/libcompizconfig/src/compiz.cpp:735]: (performance) Variable 'readonly' is reassigned a value before the old one has been used.

Other minor issues:

* Some guaruntee->guarantee typos in comments.

* Some copyright headers are still referring to the old .c files.

* Some copyright headers are not referring to the correct file names (mainly animation file headers).

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I'm assuming the actual ccpcheck changes have been merged in already and this is just the residual typo fixes in comments?

review: Needs Information
Revision history for this message
MC Return (mc-return) wrote :

> I'm assuming the actual ccpcheck changes have been merged in already and this
> is just the residual typo fixes in comments?

No, the cppcheck fixes are in:
compizconfig/libcompizconfig/src/compiz.cpp

and:
plugins/cubeaddon/src/cubeaddon.cpp

But you are right, except those 2 the rest are just fixes/changes in comments.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Ah okay, thanks, I had missed those.

Just a reminder that too many unrelated changes in an MRQ can make the important ones easy to miss.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-02-20 07:42:08 +0000
3+++ CMakeLists.txt 2013-02-27 11:55:26 +0000
4@@ -210,7 +210,7 @@
5 add_subdirectory (plugins)
6 add_subdirectory (tests)
7
8-# Leave last - the cmake_install.cmake script is guarunteed
9+# Leave last - the cmake_install.cmake script is guaranteed
10 # to run in a single job, and we need to force GSettings
11 # schema recompilation to happen after all other install
12 # targets (there is no way to set install target dependencies)
13
14=== modified file 'compizconfig/compizconfig-python/CMakeLists.txt'
15--- compizconfig/compizconfig-python/CMakeLists.txt 2012-12-11 16:22:58 +0000
16+++ compizconfig/compizconfig-python/CMakeLists.txt 2013-02-27 11:55:26 +0000
17@@ -63,7 +63,7 @@
18 # is by using add_custom_command to "generate" it into existence.
19 # Unfortunately this has drawbacks. Namely, it is not possible for
20 # add_custom_command to depend on library targets. Because of that, there's
21-# no way that we can guaruntee that libcompizconfig.so will be linked
22+# no way that we can guarantee that libcompizconfig.so will be linked
23 # before compizconfig.so (which is required). The best that we can do
24 # there is to use add_custom_target, and make that target depend on the
25 # file,
26
27=== modified file 'compizconfig/libcompizconfig/src/compiz.cpp'
28--- compizconfig/libcompizconfig/src/compiz.cpp 2012-12-07 06:09:22 +0000
29+++ compizconfig/libcompizconfig/src/compiz.cpp 2013-02-27 11:55:26 +0000
30@@ -728,11 +728,10 @@
31 const OptionMetadata & option)
32 {
33 const char *name;
34- Bool readonly = FALSE;
35
36 name = option.name ().c_str ();
37
38- readonly = option.has_read_only () && option.read_only ();
39+ Bool readonly = option.has_read_only () && option.read_only ();
40
41 if (!strlen (name) || readonly)
42 return;
43
44=== modified file 'compizconfig/tests/compizconfig_ccs_setting_value_operators.cpp'
45--- compizconfig/tests/compizconfig_ccs_setting_value_operators.cpp 2012-09-29 04:40:41 +0000
46+++ compizconfig/tests/compizconfig_ccs_setting_value_operators.cpp 2013-02-27 11:55:26 +0000
47@@ -180,7 +180,7 @@
48
49 for (unsigned int i = 0; i < finalType; ++i)
50 {
51- /* We cannot print list values as there's no guaruntee
52+ /* We cannot print list values as there's no guarantee
53 * this is actually a list */
54 if (static_cast <CCSSettingType> (i) == TypeList)
55 os << "A list value" << std::endl;
56@@ -199,7 +199,7 @@
57
58 for (unsigned int i = 0; i < finalType; ++i)
59 {
60- /* We cannot print list values as there's no guaruntee
61+ /* We cannot print list values as there's no guarantee
62 * this is actually a list */
63 if (static_cast <CCSSettingType> (i) == TypeList)
64 os << "A list value" << std::endl;
65
66=== modified file 'plugins/animation/src/animation.cpp'
67--- plugins/animation/src/animation.cpp 2013-01-11 08:28:51 +0000
68+++ plugins/animation/src/animation.cpp 2013-02-27 11:55:26 +0000
69@@ -1,7 +1,7 @@
70 /**
71 * Animation plugin for compiz/beryl
72 *
73- * animation.c
74+ * animation.cpp
75 *
76 * Copyright : (C) 2006 Erkin Bahceci
77 * E-mail : erkinbah@gmail.com
78
79=== modified file 'plugins/animation/src/curvedfold.cpp'
80--- plugins/animation/src/curvedfold.cpp 2011-03-14 15:35:30 +0000
81+++ plugins/animation/src/curvedfold.cpp 2013-02-27 11:55:26 +0000
82@@ -1,7 +1,7 @@
83 /*
84 * Animation plugin for compiz/beryl
85 *
86- * animation.c
87+ * curvedfold.cpp
88 *
89 * Copyright : (C) 2006 Erkin Bahceci
90 * E-mail : erkinbah@gmail.com
91
92=== modified file 'plugins/animation/src/dodge.cpp'
93--- plugins/animation/src/dodge.cpp 2012-05-27 04:32:55 +0000
94+++ plugins/animation/src/dodge.cpp 2013-02-27 11:55:26 +0000
95@@ -1,7 +1,7 @@
96 /*
97 * Animation plugin for compiz/beryl
98 *
99- * animation.c
100+ * dodge.cpp
101 *
102 * Copyright : (C) 2006 Erkin Bahceci
103 * E-mail : erkinbah@gmail.com
104
105=== modified file 'plugins/animation/src/dream.cpp'
106--- plugins/animation/src/dream.cpp 2009-08-02 20:42:56 +0000
107+++ plugins/animation/src/dream.cpp 2013-02-27 11:55:26 +0000
108@@ -1,7 +1,7 @@
109 /*
110 * Animation plugin for compiz/beryl
111 *
112- * animation.c
113+ * dream.cpp
114 *
115 * Copyright : (C) 2006 Erkin Bahceci
116 * E-mail : erkinbah@gmail.com
117
118=== modified file 'plugins/animation/src/extensionplugin.cpp'
119--- plugins/animation/src/extensionplugin.cpp 2012-08-03 10:12:25 +0000
120+++ plugins/animation/src/extensionplugin.cpp 2013-02-27 11:55:26 +0000
121@@ -1,7 +1,7 @@
122 /*
123 * Animation plugin for compiz/beryl
124 *
125- * animation.c
126+ * extensionplugin.cpp
127 *
128 * Copyright : (C) 2006 Erkin Bahceci
129 * E-mail : erkinbah@gmail.com
130
131=== modified file 'plugins/animation/src/fade.cpp'
132--- plugins/animation/src/fade.cpp 2009-07-15 16:05:10 +0000
133+++ plugins/animation/src/fade.cpp 2013-02-27 11:55:26 +0000
134@@ -1,7 +1,7 @@
135 /*
136 * Animation plugin for compiz/beryl
137 *
138- * animation.c
139+ * fade.cpp
140 *
141 * Copyright : (C) 2006 Erkin Bahceci
142 * E-mail : erkinbah@gmail.com
143
144=== modified file 'plugins/animation/src/focusfade.cpp'
145--- plugins/animation/src/focusfade.cpp 2009-11-17 17:59:54 +0000
146+++ plugins/animation/src/focusfade.cpp 2013-02-27 11:55:26 +0000
147@@ -1,7 +1,7 @@
148 /*
149 * Animation plugin for compiz/beryl
150 *
151- * animation.c
152+ * focusfade.cpp
153 *
154 * Copyright : (C) 2006 Erkin Bahceci
155 * E-mail : erkinbah@gmail.com
156
157=== modified file 'plugins/animation/src/glide.cpp'
158--- plugins/animation/src/glide.cpp 2012-11-04 15:25:34 +0000
159+++ plugins/animation/src/glide.cpp 2013-02-27 11:55:26 +0000
160@@ -1,7 +1,7 @@
161 /*
162 * Animation plugin for compiz/beryl
163 *
164- * animation.c
165+ * glide.cpp
166 *
167 * Copyright : (C) 2006 Erkin Bahceci
168 * E-mail : erkinbah@gmail.com
169
170=== modified file 'plugins/animation/src/grid.cpp'
171--- plugins/animation/src/grid.cpp 2012-11-19 21:02:02 +0000
172+++ plugins/animation/src/grid.cpp 2013-02-27 11:55:26 +0000
173@@ -1,7 +1,7 @@
174 /*
175 * Animation plugin for compiz/beryl
176 *
177- * animation.c
178+ * grid.cpp
179 *
180 * Copyright : (C) 2006 Erkin Bahceci
181 * E-mail : erkinbah@gmail.com
182
183=== modified file 'plugins/animation/src/horizontalfold.cpp'
184--- plugins/animation/src/horizontalfold.cpp 2009-08-02 20:42:56 +0000
185+++ plugins/animation/src/horizontalfold.cpp 2013-02-27 11:55:26 +0000
186@@ -1,7 +1,7 @@
187 /*
188 * Animation plugin for compiz/beryl
189 *
190- * animation.c
191+ * horizontalfold.cpp
192 *
193 * Copyright : (C) 2006 Erkin Bahceci
194 * E-mail : erkinbah@gmail.com
195
196=== modified file 'plugins/animation/src/magiclamp.cpp'
197--- plugins/animation/src/magiclamp.cpp 2012-11-04 15:38:49 +0000
198+++ plugins/animation/src/magiclamp.cpp 2013-02-27 11:55:26 +0000
199@@ -1,7 +1,7 @@
200 /*
201 * Animation plugin for compiz/beryl
202 *
203- * animation.c
204+ * magiclamp.cpp
205 *
206 * Copyright : (C) 2006 Erkin Bahceci
207 * E-mail : erkinbah@gmail.com
208
209=== modified file 'plugins/animation/src/options.cpp'
210--- plugins/animation/src/options.cpp 2012-09-04 10:00:14 +0000
211+++ plugins/animation/src/options.cpp 2013-02-27 11:55:26 +0000
212@@ -1,7 +1,7 @@
213 /*
214 * Animation plugin for compiz/beryl
215 *
216- * animation.c
217+ * options.cpp
218 *
219 * Copyright : (C) 2006 Erkin Bahceci
220 * E-mail : erkinbah@gmail.com
221
222=== modified file 'plugins/animation/src/restack.cpp'
223--- plugins/animation/src/restack.cpp 2011-03-14 15:35:30 +0000
224+++ plugins/animation/src/restack.cpp 2013-02-27 11:55:26 +0000
225@@ -1,7 +1,7 @@
226 /*
227 * Animation plugin for compiz/beryl
228 *
229- * animation.c
230+ * restack.cpp
231 *
232 * Copyright : (C) 2006 Erkin Bahceci
233 * E-mail : erkinbah@gmail.com
234
235=== modified file 'plugins/animation/src/rollup.cpp'
236--- plugins/animation/src/rollup.cpp 2009-08-02 20:42:56 +0000
237+++ plugins/animation/src/rollup.cpp 2013-02-27 11:55:26 +0000
238@@ -1,7 +1,7 @@
239 /*
240 * Animation plugin for compiz/beryl
241 *
242- * animation.c
243+ * rollup.cpp
244 *
245 * Copyright : (C) 2006 Erkin Bahceci
246 * E-mail : erkinbah@gmail.com
247
248=== modified file 'plugins/animation/src/wave.cpp'
249--- plugins/animation/src/wave.cpp 2009-08-02 20:42:56 +0000
250+++ plugins/animation/src/wave.cpp 2013-02-27 11:55:26 +0000
251@@ -1,7 +1,7 @@
252 /*
253 * Animation plugin for compiz/beryl
254 *
255- * animation.c
256+ * wave.cpp
257 *
258 * Copyright : (C) 2006 Erkin Bahceci
259 * E-mail : erkinbah@gmail.com
260
261=== modified file 'plugins/animation/src/zoomside.cpp'
262--- plugins/animation/src/zoomside.cpp 2011-03-14 15:35:30 +0000
263+++ plugins/animation/src/zoomside.cpp 2013-02-27 11:55:26 +0000
264@@ -1,7 +1,7 @@
265 /*
266 * Animation plugin for compiz/beryl
267 *
268- * animation.c
269+ * zoomside.cpp
270 *
271 * Copyright : (C) 2006 Erkin Bahceci
272 * E-mail : erkinbah@gmail.com
273
274=== modified file 'plugins/animationaddon/src/airplane.cpp'
275--- plugins/animationaddon/src/airplane.cpp 2012-05-25 02:27:04 +0000
276+++ plugins/animationaddon/src/airplane.cpp 2013-02-27 11:55:26 +0000
277@@ -1,7 +1,7 @@
278 /*
279 * Animation plugin for compiz/beryl
280 *
281- * airplane3d.c
282+ * airplane.cpp (based on airplane3d.c)
283 *
284 * Copyright : (C) 2006 Erkin Bahceci
285 * E-mail : erkinbah@gmail.com
286
287=== modified file 'plugins/animationaddon/src/animationaddon.cpp'
288--- plugins/animationaddon/src/animationaddon.cpp 2012-09-07 22:37:20 +0000
289+++ plugins/animationaddon/src/animationaddon.cpp 2013-02-27 11:55:26 +0000
290@@ -1,7 +1,7 @@
291 /**
292 * Animation plugin for compiz/beryl
293 *
294- * animation.c
295+ * animationaddon.cpp
296 *
297 * Copyright : (C) 2006 Erkin Bahceci
298 * E-mail : erkinbah@gmail.com
299
300=== modified file 'plugins/animationaddon/src/beamup.cpp'
301--- plugins/animationaddon/src/beamup.cpp 2011-02-22 13:05:27 +0000
302+++ plugins/animationaddon/src/beamup.cpp 2013-02-27 11:55:26 +0000
303@@ -1,7 +1,7 @@
304 /*
305 * Animation plugin for compiz/beryl
306 *
307- * animation.c
308+ * beamup.cpp
309 *
310 * Copyright : (C) 2006 Erkin Bahceci
311 * E-mail : erkinbah@gmail.com
312
313=== modified file 'plugins/animationaddon/src/burn.cpp'
314--- plugins/animationaddon/src/burn.cpp 2012-07-30 09:20:41 +0000
315+++ plugins/animationaddon/src/burn.cpp 2013-02-27 11:55:26 +0000
316@@ -1,7 +1,7 @@
317 /*
318 * Animation plugin for compiz/beryl
319 *
320- * animation.c
321+ * burn.cpp
322 *
323 * Copyright : (C) 2006 Erkin Bahceci
324 * E-mail : erkinbah@gmail.com
325
326=== modified file 'plugins/animationaddon/src/domino.cpp'
327--- plugins/animationaddon/src/domino.cpp 2010-01-27 05:53:22 +0000
328+++ plugins/animationaddon/src/domino.cpp 2013-02-27 11:55:26 +0000
329@@ -1,7 +1,7 @@
330 /*
331 * Animation plugin for compiz/beryl
332 *
333- * animation.c
334+ * domino.cpp
335 *
336 * Copyright : (C) 2006 Erkin Bahceci
337 * E-mail : erkinbah@gmail.com
338
339=== modified file 'plugins/animationaddon/src/explode.cpp'
340--- plugins/animationaddon/src/explode.cpp 2010-01-27 05:53:22 +0000
341+++ plugins/animationaddon/src/explode.cpp 2013-02-27 11:55:26 +0000
342@@ -1,7 +1,7 @@
343 /*
344 * Animation plugin for compiz/beryl
345 *
346- * animation.c
347+ * explode.cpp
348 *
349 * Copyright : (C) 2006 Erkin Bahceci
350 * E-mail : erkinbah@gmail.com
351
352=== modified file 'plugins/animationaddon/src/fold.cpp'
353--- plugins/animationaddon/src/fold.cpp 2011-03-14 16:00:55 +0000
354+++ plugins/animationaddon/src/fold.cpp 2013-02-27 11:55:26 +0000
355@@ -1,7 +1,7 @@
356 /**
357 * Animation plugin for compiz/beryl
358 *
359- * animation.c
360+ * fold.cpp
361 *
362 * Copyright : (C) 2006 Erkin Bahceci
363 * E-mail : erkinbah@gmail.com
364
365=== modified file 'plugins/animationaddon/src/glide3.cpp'
366--- plugins/animationaddon/src/glide3.cpp 2010-01-27 05:53:22 +0000
367+++ plugins/animationaddon/src/glide3.cpp 2013-02-27 11:55:26 +0000
368@@ -1,7 +1,7 @@
369 /*
370 * Animation plugin for compiz/beryl
371 *
372- * animation.c
373+ * glide3.cpp
374 *
375 * Copyright : (C) 2006 Erkin Bahceci
376 * E-mail : erkinbah@gmail.com
377
378=== modified file 'plugins/animationaddon/src/leafspread.cpp'
379--- plugins/animationaddon/src/leafspread.cpp 2010-01-27 05:53:22 +0000
380+++ plugins/animationaddon/src/leafspread.cpp 2013-02-27 11:55:26 +0000
381@@ -1,7 +1,7 @@
382 /*
383 * Animation plugin for compiz/beryl
384 *
385- * animation.c
386+ * leafspread.cpp
387 *
388 * Copyright : (C) 2006 Erkin Bahceci
389 * E-mail : erkinbah@gmail.com
390
391=== modified file 'plugins/animationaddon/src/particle.cpp'
392--- plugins/animationaddon/src/particle.cpp 2012-05-25 06:10:15 +0000
393+++ plugins/animationaddon/src/particle.cpp 2013-02-27 11:55:26 +0000
394@@ -1,7 +1,7 @@
395 /*
396 * Animation plugin for compiz/beryl
397 *
398- * animation.c
399+ * particle.cpp
400 *
401 * Copyright : (C) 2006 Erkin Bahceci
402 * E-mail : erkinbah@gmail.com
403
404=== modified file 'plugins/animationaddon/src/polygon.cpp'
405--- plugins/animationaddon/src/polygon.cpp 2012-09-05 18:23:22 +0000
406+++ plugins/animationaddon/src/polygon.cpp 2013-02-27 11:55:26 +0000
407@@ -1,7 +1,7 @@
408 /*
409 * Animation plugin for compiz/beryl
410 *
411- * animation.c
412+ * polygon.cpp
413 *
414 * Copyright : (C) 2006 Erkin Bahceci
415 * E-mail : erkinbah@gmail.com
416
417=== modified file 'plugins/animationaddon/src/skewer.cpp'
418--- plugins/animationaddon/src/skewer.cpp 2010-01-27 05:53:22 +0000
419+++ plugins/animationaddon/src/skewer.cpp 2013-02-27 11:55:26 +0000
420@@ -1,7 +1,7 @@
421 /**
422 * Animation plugin for compiz/beryl
423 *
424- * animation.c
425+ * skewer.cpp
426 *
427 * Copyright : (C) 2006 Erkin Bahceci
428 * E-mail : erkinbah@gmail.com
429
430=== modified file 'plugins/bench/src/bench.cpp'
431--- plugins/bench/src/bench.cpp 2012-09-05 18:23:22 +0000
432+++ plugins/bench/src/bench.cpp 2013-02-27 11:55:26 +0000
433@@ -2,7 +2,7 @@
434 *
435 * Compiz benchmark plugin
436 *
437- * bench.c
438+ * bench.cpp
439 *
440 * Copyright : (C) 2006 by Dennis Kasprzyk
441 * E-mail : onestone@beryl-project.org
442
443=== modified file 'plugins/cubeaddon/src/cubeaddon.cpp'
444--- plugins/cubeaddon/src/cubeaddon.cpp 2013-01-04 09:14:39 +0000
445+++ plugins/cubeaddon/src/cubeaddon.cpp 2013-02-27 11:55:26 +0000
446@@ -317,9 +317,7 @@
447 CompOutput *output,
448 PaintOrder order)
449 {
450- bool rv = false;
451-
452- rv = cubeScreen->cubeShouldPaintViewport (sAttrib, transform,
453+ bool rv = cubeScreen->cubeShouldPaintViewport (sAttrib, transform,
454 output, order);
455
456 if (rv || cubeScreen->unfolded ())
457
458=== modified file 'plugins/expo/src/expo.cpp'
459--- plugins/expo/src/expo.cpp 2012-12-04 15:35:36 +0000
460+++ plugins/expo/src/expo.cpp 2013-02-27 11:55:26 +0000
461@@ -2,7 +2,7 @@
462 *
463 * Compiz expo plugin
464 *
465- * expo.c
466+ * expo.cpp
467 *
468 * Copyright (c) 2011 Linaro Limited
469 * Copyright (c) 2008 Dennis Kasprzyk <racarr@opencompositing.org>
470
471=== modified file 'plugins/firepaint/src/firepaint.cpp'
472--- plugins/firepaint/src/firepaint.cpp 2013-02-26 21:29:59 +0000
473+++ plugins/firepaint/src/firepaint.cpp 2013-02-27 11:55:26 +0000
474@@ -1,7 +1,7 @@
475 /*
476 * Compiz fire effect plugin
477 *
478- * firepaint.c
479+ * firepaint.cpp
480 *
481 * Copyright : (C) 2007 by Dennis Kasprzyk
482 * E-mail : onestone@beryl-project.org
483
484=== modified file 'plugins/group/src/group.h'
485--- plugins/group/src/group.h 2012-09-07 22:48:26 +0000
486+++ plugins/group/src/group.h 2013-02-27 11:55:26 +0000
487@@ -414,14 +414,14 @@
488 void
489 computeGlowQuads (GLTexture::Matrix *matrix);
490
491- /* paint.c */
492+ /* paint.cpp */
493
494 void
495 getStretchRectangle (CompRect &box,
496 float &xScaleRet,
497 float &yScaleRet);
498
499- /* queues.c */
500+ /* queues.cpp */
501
502 void
503 enqueueMoveNotify (int dx,
504@@ -438,13 +438,13 @@
505 void
506 enqueueUngrabNotify ();
507
508- /* selection.c */
509+ /* selection.cpp */
510
511 bool
512 windowInRegion (CompRegion src,
513 float precision);
514
515- /* group.c */
516+ /* group.cpp */
517
518 bool
519 isGroupWindow ();
520@@ -593,12 +593,12 @@
521 bool
522 applyInitialActions ();
523
524- /* cairo.c */
525+ /* cairo.cpp */
526
527 void
528 damagePaintRectangle (const CompRect &box);
529
530- /* queues.c */
531+ /* queues.cpp */
532
533 void
534 dequeueSyncs (GroupWindow::PendingSyncs *);
535@@ -615,7 +615,7 @@
536 bool
537 dequeueTimer ();
538
539- /* selection.c */
540+ /* selection.cpp */
541
542 bool
543 selectSingle (CompAction *action,
544@@ -631,7 +631,7 @@
545 CompAction::State state,
546 CompOption::Vector options);
547
548- /* group.c */
549+ /* group.cpp */
550
551 void
552 grabScreen (GroupScreen::GrabState newState);
553@@ -681,7 +681,7 @@
554 handleMotionEvent (int xRoot,
555 int yRoot);
556
557- /* tab.c */
558+ /* tab.cpp */
559
560 bool
561 getCurrentMousePosition (int &x, int &y);
562
563=== modified file 'plugins/imgjpeg/src/imgjpeg.cpp'
564--- plugins/imgjpeg/src/imgjpeg.cpp 2012-12-04 12:09:36 +0000
565+++ plugins/imgjpeg/src/imgjpeg.cpp 2013-02-27 11:55:26 +0000
566@@ -1,4 +1,6 @@
567 /*
568+ * jpeg.cpp
569+ * based on:
570 * beryl-plugins::jpeg.c - adds JPEG image support to beryl.
571 * Copyright: (C) 2006 Nicholas Thomas
572 * Danny Baumann (JPEG writing, option stuff)
573
574=== modified file 'plugins/mag/src/mag.cpp'
575--- plugins/mag/src/mag.cpp 2012-09-04 15:33:44 +0000
576+++ plugins/mag/src/mag.cpp 2013-02-27 11:55:26 +0000
577@@ -2,7 +2,7 @@
578 *
579 * Compiz magnifier plugin
580 *
581- * mag.c
582+ * mag.cpp
583 *
584 * Copyright : (C) 2008 by Dennis Kasprzyk
585 * E-mail : onestone@opencompositing.org
586
587=== modified file 'plugins/mousepoll/src/mousepoll.cpp'
588--- plugins/mousepoll/src/mousepoll.cpp 2012-10-12 09:05:18 +0000
589+++ plugins/mousepoll/src/mousepoll.cpp 2013-02-27 11:55:26 +0000
590@@ -2,7 +2,7 @@
591 *
592 * Compiz mouse position polling plugin
593 *
594- * mousepoll.c
595+ * mousepoll.cpp
596 *
597 * Copyright : (C) 2008 by Dennis Kasprzyk
598 * E-mail : onestone@opencompositing.org
599
600=== modified file 'plugins/resizeinfo/src/resizeinfo.cpp'
601--- plugins/resizeinfo/src/resizeinfo.cpp 2013-02-03 19:12:44 +0000
602+++ plugins/resizeinfo/src/resizeinfo.cpp 2013-02-27 11:55:26 +0000
603@@ -2,7 +2,7 @@
604 *
605 * Compiz metacity like info during resize
606 *
607- * resizeinfo.c
608+ * resizeinfo.cpp
609 *
610 * Copyright (c) 2007 Robert Carr <racarr@opencompositing.org>
611 *
612
613=== modified file 'plugins/scalefilter/src/scalefilter.cpp'
614--- plugins/scalefilter/src/scalefilter.cpp 2012-05-28 08:39:10 +0000
615+++ plugins/scalefilter/src/scalefilter.cpp 2013-02-27 11:55:26 +0000
616@@ -2,7 +2,7 @@
617 *
618 * Compiz scale window title filter plugin
619 *
620- * scalefilter.c
621+ * scalefilter.cpp
622 *
623 * Copyright : (C) 2007 by Danny Baumann
624 * E-mail : maniac@opencompositing.org
625
626=== modified file 'plugins/session/src/session.cpp'
627--- plugins/session/src/session.cpp 2012-07-30 10:06:24 +0000
628+++ plugins/session/src/session.cpp 2013-02-27 11:55:26 +0000
629@@ -2,7 +2,7 @@
630 *
631 * Compiz session plugin
632 *
633- * session.c
634+ * session.cpp
635 *
636 * Copyright (c) 2008 Travis Watkins <amaranth@ubuntu.com>
637 * Copyright (c) 2008 Danny Baumann <maniac@opencompositing.org>
638
639=== modified file 'plugins/text/src/text.cpp'
640--- plugins/text/src/text.cpp 2012-10-19 10:29:49 +0000
641+++ plugins/text/src/text.cpp 2013-02-27 11:55:26 +0000
642@@ -2,7 +2,7 @@
643 * Compiz text plugin
644 * Description: Adds text to pixmap support to Compiz.
645 *
646- * text.c
647+ * text.cpp
648 *
649 * Copyright: (C) 2006-2007 Patrick Niklaus, Danny Baumann, Dennis Kasprzyk
650 * Authors: Patrick Niklaus <marex@opencompsiting.org>
651
652=== modified file 'plugins/trip/src/trip.cpp'
653--- plugins/trip/src/trip.cpp 2012-11-05 00:26:30 +0000
654+++ plugins/trip/src/trip.cpp 2013-02-27 11:55:26 +0000
655@@ -2,7 +2,7 @@
656 *
657 * Compiz trip plugin
658 *
659- * trip.c
660+ * trip.cpp
661 *
662 * Copyright : (C) 2010 by Scott Moreau
663 * E-mail : oreaus@gmail.com
664
665=== modified file 'plugins/wall/src/offset_movement/src/offset-movement.cpp'
666--- plugins/wall/src/offset_movement/src/offset-movement.cpp 2012-08-13 05:46:59 +0000
667+++ plugins/wall/src/offset_movement/src/offset-movement.cpp 2013-02-27 11:55:26 +0000
668@@ -2,7 +2,7 @@
669 *
670 * Compiz wall plugin
671 *
672- * offset-movement.c
673+ * offset-movement.cpp
674 *
675 * Copyright (c) 2006 Robert Carr <racarr@beryl-project.org>
676 *
677
678=== modified file 'plugins/widget/src/widget.cpp'
679--- plugins/widget/src/widget.cpp 2012-12-10 05:35:03 +0000
680+++ plugins/widget/src/widget.cpp 2013-02-27 11:55:26 +0000
681@@ -2,7 +2,7 @@
682 *
683 * Compiz widget handling plugin
684 *
685- * widget.c
686+ * widget.cpp
687 *
688 * Copyright : (C) 2007 by Danny Baumann
689 * E-mail : maniac@opencompositing.org
690
691=== modified file 'src/pluginclasshandler/include/core/pluginclasshandler.h'
692--- src/pluginclasshandler/include/core/pluginclasshandler.h 2012-12-10 05:35:03 +0000
693+++ src/pluginclasshandler/include/core/pluginclasshandler.h 2013-02-27 11:55:26 +0000
694@@ -34,7 +34,7 @@
695 #include <core/pluginclasses.h>
696
697 /* Continuously increments every time a new
698- * plugin class is added, guarunteed to be
699+ * plugin class is added, guaranteed to be
700 * the same as the pcIndex of the most up-to-date
701 * PluginClassHandler index. Any index that
702 * hold the same value this value is safe to
703
704=== modified file 'src/timer/tests/set-values/src/test-timer-set-values.cpp'
705--- src/timer/tests/set-values/src/test-timer-set-values.cpp 2012-01-12 06:48:58 +0000
706+++ src/timer/tests/set-values/src/test-timer-set-values.cpp 2013-02-27 11:55:26 +0000
707@@ -36,7 +36,7 @@
708 usleep (100000);
709
710 /* minLeft and maxLeft are now
711- * real-time, so wait the guarunteed
712+ * real-time, so wait the guaranteed
713 * expiry time in order to check them
714 * for an accurate value of zero */
715
716
717=== modified file 'tests/system/xorg-gtest/tests/compiz_xorg_gtest_test_window_stacking.cpp'
718--- tests/system/xorg-gtest/tests/compiz_xorg_gtest_test_window_stacking.cpp 2013-02-12 22:43:18 +0000
719+++ tests/system/xorg-gtest/tests/compiz_xorg_gtest_test_window_stacking.cpp 2013-02-27 11:55:26 +0000
720@@ -329,7 +329,7 @@
721 ASSERT_TRUE (Advance (dpy, ct::WaitForEventOfTypeOnWindow (dpy,w1, ReparentNotify, -1, -1)));
722 ASSERT_TRUE (Advance (dpy, ct::WaitForEventOfTypeOnWindow (dpy, w1, MapNotify, -1, -1)));
723
724- /* Grab the server so that we can guaruntee that all of these requests
725+ /* Grab the server so that we can guarantee that all of these requests
726 * happen before compiz gets them */
727 XGrabServer (dpy);
728 XSync (dpy, false);

Subscribers

People subscribed via source and target branches