Merge lp:~mc-return/compiz/compiz.merge-fix1134251-minor-issues into lp:compiz/0.9.9
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Sam Spilsbury | ||||
Approved revision: | 3626 | ||||
Merged at revision: | 3628 | ||||
Proposed branch: | lp:~mc-return/compiz/compiz.merge-fix1134251-minor-issues | ||||
Merge into: | lp:compiz/0.9.9 | ||||
Diff against target: |
728 lines (+60/-61) 50 files modified
CMakeLists.txt (+1/-1) compizconfig/compizconfig-python/CMakeLists.txt (+1/-1) compizconfig/libcompizconfig/src/compiz.cpp (+1/-2) compizconfig/tests/compizconfig_ccs_setting_value_operators.cpp (+2/-2) plugins/animation/src/animation.cpp (+1/-1) plugins/animation/src/curvedfold.cpp (+1/-1) plugins/animation/src/dodge.cpp (+1/-1) plugins/animation/src/dream.cpp (+1/-1) plugins/animation/src/extensionplugin.cpp (+1/-1) plugins/animation/src/fade.cpp (+1/-1) plugins/animation/src/focusfade.cpp (+1/-1) plugins/animation/src/glide.cpp (+1/-1) plugins/animation/src/grid.cpp (+1/-1) plugins/animation/src/horizontalfold.cpp (+1/-1) plugins/animation/src/magiclamp.cpp (+1/-1) plugins/animation/src/options.cpp (+1/-1) plugins/animation/src/restack.cpp (+1/-1) plugins/animation/src/rollup.cpp (+1/-1) plugins/animation/src/wave.cpp (+1/-1) plugins/animation/src/zoomside.cpp (+1/-1) plugins/animationaddon/src/airplane.cpp (+1/-1) plugins/animationaddon/src/animationaddon.cpp (+1/-1) plugins/animationaddon/src/beamup.cpp (+1/-1) plugins/animationaddon/src/burn.cpp (+1/-1) plugins/animationaddon/src/domino.cpp (+1/-1) plugins/animationaddon/src/explode.cpp (+1/-1) plugins/animationaddon/src/fold.cpp (+1/-1) plugins/animationaddon/src/glide3.cpp (+1/-1) plugins/animationaddon/src/leafspread.cpp (+1/-1) plugins/animationaddon/src/particle.cpp (+1/-1) plugins/animationaddon/src/polygon.cpp (+1/-1) plugins/animationaddon/src/skewer.cpp (+1/-1) plugins/bench/src/bench.cpp (+1/-1) plugins/cubeaddon/src/cubeaddon.cpp (+1/-3) plugins/expo/src/expo.cpp (+1/-1) plugins/firepaint/src/firepaint.cpp (+1/-1) plugins/group/src/group.h (+9/-9) plugins/imgjpeg/src/imgjpeg.cpp (+2/-0) plugins/mag/src/mag.cpp (+1/-1) plugins/mousepoll/src/mousepoll.cpp (+1/-1) plugins/resizeinfo/src/resizeinfo.cpp (+1/-1) plugins/scalefilter/src/scalefilter.cpp (+1/-1) plugins/session/src/session.cpp (+1/-1) plugins/text/src/text.cpp (+1/-1) plugins/trip/src/trip.cpp (+1/-1) plugins/wall/src/offset_movement/src/offset-movement.cpp (+1/-1) plugins/widget/src/widget.cpp (+1/-1) src/pluginclasshandler/include/core/pluginclasshandler.h (+1/-1) src/timer/tests/set-values/src/test-timer-set-values.cpp (+1/-1) tests/system/xorg-gtest/tests/compiz_xorg_gtest_test_window_stacking.cpp (+1/-1) |
||||
To merge this branch: | bzr merge lp:~mc-return/compiz/compiz.merge-fix1134251-minor-issues | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sam Spilsbury | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+150768@code.launchpad.net |
Commit message
Fixed minor cppcheck issues:
Do not assign a value to rv, because this value is never used.
Instead declare and assign a value to bool rv in the same line.
Do not assign false to Bool readonly, because this value is never used.
Instead declare the variable and assign a value in the same line.
Other minor problems:
Fixed some guaruntee-
Fixed copyright headers still referring to the old .c files.
Fixed wrong names in copyright headers.
(LP: #1134251)
Description of the change
cppcheck reports these valid issues:
[plugins/
[compizconfig/
Other minor issues:
* Some guaruntee-
* Some copyright headers are still referring to the old .c files.
* Some copyright headers are not referring to the correct file names (mainly animation file headers).
I'm assuming the actual ccpcheck changes have been merged in already and this is just the residual typo fixes in comments?