lp:~mc-return/compiz/compiz.merge-fix1114525-cppcheck-reveals-true-positives

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9 at revision 3598

Sam Spilsbury: Approve on 2013-02-06

PS Jenkins bot: Pending (continuous-integration) requested 2013-02-06

Diff: 157 lines (+13/-19)

9 files modified

plugins/decor/src/decor.cpp (+1/-1)
plugins/expo/src/glow.cpp (+1/-1)
plugins/resize/src/logic/src/resize-logic.cpp (+5/-7)
plugins/resizeinfo/src/resizeinfo.cpp (+1/-1)
plugins/td/src/3d.cpp (+1/-3)
plugins/thumbnail/src/thumbnail.cpp (+0/-1)
plugins/trailfocus/src/trailfocus.cpp (+0/-1)
src/screen.cpp (+1/-1)
src/window.cpp (+3/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1114525: cppcheck static code analysis reveals some true positives

Medium

Fix Released

Link a bug report

Related blueprints

3602. By MC Return on 2013-02-03

xv and yv are of type unsigned int, so we %u is the right
format to snprintf them, not %d

3601. By MC Return on 2013-02-03

int lco, rco, tco and bco got the value output assigned, but this
value never was used, but all got new values assigned a few lines
later
Declare and assign int lco, rco, tco and bco in the same line

3600. By MC Return on 2013-02-03

Commented out calculation of x2, because this value gets recalculated
a few lines later before having been used

3599. By MC Return on 2013-02-03

Use prefix ++ operators to increase w (x2) and it in their for loops,
because pre-increment can be more efficient

3598. By MC Return on 2013-02-03

Use prefix ++ operator to increase rit in the for loop,
because pre-increment can be more efficient

3597. By MC Return on 2013-02-03

Do not assign false to bool rv, because a new value is reassigned
a few lines later, before the old one has been used
Declare and assign bool rv in the same line instead

3596. By MC Return on 2013-02-03

Removed useless calculation of distance, because the calculated value is never used

3595. By MC Return on 2013-02-03

Removed unused variable TfWindowList::iterator iter in TrailfocusScreen::refillList ()

3594. By MC Return on 2013-02-02

quilt ubuntu-config.patch refresh:
The unmaximize_or_minimize_window_key replaces the unmaximize_window_key, so
Ctrl+Super+Down is now the shortcut for the unmaximize_or_minimize_window_key.

(LP: #966099). Fixes: https://bugs.launchpad.net/bugs/966099.

Approved by Michael Terry.

3593. By MC Return on 2013-02-01

Thumbnail plugin, new features:

Added a rounded background to the window title text.

Made the distance between text and thumbnail configurable.

Window-like-background or glow are now rendered around
the thumbnail live preview only, excluding the text.
This ensures no transparent hole is generated anymore and
fixes the look of the window title text rendering, while
enhancing the possibility for customization.

Code cleanup:

Return ASAP if the text plugin is not loaded.
No need to check if (t->text) twice.
Improved height calculation.

thumbnail.xml.in changes:

Added options to adjust the text distance (pixel between
thumbnail and window title text) and font background color
and opacity.

Made the window title text font white and fully opaque
to create a sane default, otherwise it would not be
visible on a transparent black background (alpha and color
are the same like the default background/glow color).

(LP: #1099100). Fixes: https://bugs.launchpad.net/bugs/1099100.

Approved by Brandon Schaefer, Sam Spilsbury.