Merge lp:~mc-return/compiz/compiz.merge-fix1101557-missing-break into lp:compiz/0.9.9

Proposed by MC Return on 2013-01-19
Status: Merged
Approved by: Daniel van Vugt on 2013-01-22
Approved revision: 3570
Merged at revision: 3574
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix1101557-missing-break
Merge into: lp:compiz/0.9.9
Diff against target: 11 lines (+1/-0)
1 file modified
plugins/ccp/src/ccp.cpp (+1/-0)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix1101557-missing-break
Reviewer Review Type Date Requested Status
Daniel van Vugt 2013-01-19 Approve on 2013-01-22
PS Jenkins bot continuous-integration Pending
Review via email: mp+143984@code.launchpad.net

Commit message

Added missing break to ccpInitValue (CCSSettingValue *value, CompOption::Value *from, CCSSettingType type) function.

(LP: #1101557)

To post a comment you must log in.
Daniel van Vugt (vanvugt) wrote :

Scary. Seems to work still. No obvious changes in behaviour.

review: Approve
Daniel van Vugt (vanvugt) wrote :

I wonder how much this relates to the problems people report with key bindings being unreliable since 0.9.8.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/ccp/src/ccp.cpp'
2--- plugins/ccp/src/ccp.cpp 2012-09-05 17:42:18 +0000
3+++ plugins/ccp/src/ccp.cpp 2013-01-19 12:36:21 +0000
4@@ -266,6 +266,7 @@
5 value->value.asKey.keysym = 0;
6 value->value.asKey.keyModMask = 0;
7 }
8+ break;
9 case TypeButton:
10 if (from->action ().type () & CompAction::BindingTypeButton)
11 {

Subscribers

People subscribed via source and target branches