Merge lp:~mc-return/compiz/compiz.merge-fix1075600-workspacenames-default-appearance-values-not-ideal into lp:compiz/0.9.9

Proposed by MC Return
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3455
Merged at revision: 3465
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix1075600-workspacenames-default-appearance-values-not-ideal
Merge into: lp:compiz/0.9.9
Diff against target: 27 lines (+3/-3)
1 file modified
plugins/workspacenames/workspacenames.xml.in (+3/-3)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix1075600-workspacenames-default-appearance-values-not-ideal
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
MC Return Needs Resubmitting
PS Jenkins bot continuous-integration Pending
Review via email: mp+133127@code.launchpad.net

Commit message

Improved default workspacenames.xml.in values:

* Increased default display time from 0.5 to 1.5 seconds
* Bold text display is now default
* Increased default font size from 16 to 24 pixel

(LP: #1075600)

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Two problems:

1. You're making two unrelated changes in one branch; changing strings and changing the default appearance.

2. We usually don't want to change the default appearance for any established compiz plugins. However I will test the branch and see if I agree it looks better after #1 is fixed.

review: Needs Fixing
3455. By MC Return

Reverted the string changes in workspacenames.xml.in

Revision history for this message
MC Return (mc-return) wrote :

> Two problems:
>
> 1. You're making two unrelated changes in one branch; changing strings and
> changing the default appearance.
>
> 2. We usually don't want to change the default appearance for any established
> compiz plugins. However I will test the branch and see if I agree it looks
> better after #1 is fixed.

#1 was fixed in r3455. This branch is just about changing default appearance of workspacenames now.

review: Needs Resubmitting
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yeah I think this looks good. I wonder if that's only because I have a large monitor though.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/workspacenames/workspacenames.xml.in'
2--- plugins/workspacenames/workspacenames.xml.in 2012-11-06 19:32:06 +0000
3+++ plugins/workspacenames/workspacenames.xml.in 2012-11-10 12:04:20 +0000
4@@ -53,7 +53,7 @@
5 <min>0.1</min>
6 <max>5.0</max>
7 <precision>0.05</precision>
8- <default>0.5</default>
9+ <default>1.5</default>
10 </option>
11 <option name="fade_time" type="float">
12 <_short>Fade Time</_short>
13@@ -68,12 +68,12 @@
14 <option name="bold_text" type="bool">
15 <_short>Bold Font</_short>
16 <_long>Selects if the text should be displayed in bold font or not.</_long>
17- <default>false</default>
18+ <default>true</default>
19 </option>
20 <option name="text_font_size" type="int">
21 <_short>Font Size</_short>
22 <_long>Font size for the text display.</_long>
23- <default>16</default>
24+ <default>24</default>
25 <min>6</min>
26 <max>96</max>
27 </option>

Subscribers

People subscribed via source and target branches