Merge lp:~mc-return/compiz/compiz.merge-fix1070782-stackswitcher-ignores-setting-show-window-title into lp:compiz/0.9.10

Proposed by MC Return
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3441
Merged at revision: 3648
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix1070782-stackswitcher-ignores-setting-show-window-title
Merge into: lp:compiz/0.9.10
Diff against target: 38 lines (+12/-6)
1 file modified
plugins/stackswitch/src/stackswitch.cpp (+12/-6)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix1070782-stackswitcher-ignores-setting-show-window-title
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
Review via email: mp+157051@code.launchpad.net

Commit message

Stack (Window) Switcher
(currently excluded from compilation):

Fixed window title drawn although "Show Window Title" is disabled.

(LP: #1070782)

Description of the change

Note:
Stack Window Switcher is currently excluded from compilation, because of the GLES merge.
Hopefully this will be fixed soon, it is on my (long) TODO list.
This change was already rejected one time, but this fix will have to go in sooner or later in the exactly same form anyway.

So better do it now to have it done...

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/stackswitch/src/stackswitch.cpp'
2--- plugins/stackswitch/src/stackswitch.cpp 2011-03-14 16:11:45 +0000
3+++ plugins/stackswitch/src/stackswitch.cpp 2013-04-04 09:03:25 +0000
4@@ -86,15 +86,15 @@
5 void
6 StackswitchScreen::renderWindowTitle ()
7 {
8+ if (!textAvailable)
9+ return;
10+
11+ if (!optionGetWindowTitle ())
12+ return;
13+
14 CompText::Attrib tA;
15 bool showViewport;
16
17- if (!textAvailable)
18- return;
19-
20- if (!optionGetWindowTitle ())
21- return;
22-
23 CompRect oe = screen->getCurrentOutputExtents ();
24
25 /* 75% of the output device as maximum width */
26@@ -127,6 +127,12 @@
27 StackswitchScreen::drawWindowTitle (GLMatrix &transform,
28 CompWindow *w)
29 {
30+ if (!textAvailable)
31+ return;
32+
33+ if (!optionGetWindowTitle ())
34+ return;
35+
36 GLboolean wasBlend;
37 GLint oldBlendSrc, oldBlendDst;
38 GLMatrix wTransform (transform), mvp;

Subscribers

People subscribed via source and target branches

to all changes: