Merge lp:~mc-return/compiz/compiz.merge-fix1067534 into lp:compiz/0.9.9

Proposed by MC Return
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3432
Merged at revision: 3435
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix1067534
Merge into: lp:compiz/0.9.9
Diff against target: 23 lines (+2/-0)
2 files modified
plugins/fadedesktop/fadedesktop.xml.in (+1/-0)
plugins/showdesktop/showdesktop.xml.in (+1/-0)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix1067534
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Marco Trevisan (Treviño) Approve
Omer Akram (community) Approve
Review via email: mp+130001@code.launchpad.net

Commit message

Make sure showdesktop is loaded after unityshell.
(LP: #1067534)

fadedesktop conflicts with unityshell and showdesktop now.
showdesktop still conflicts with fadesktop, but not with unityshell anymore.

Together with the fix for Unity this allows the CCSM user to use the full functionality of the "Show Desktop" plug-in together with Unity-3d for the first time, namely sliding windows out of view to show the desktop and sliding them back in to restore the previous state.

Description of the change

Problem:
The default behaviour (before recent fixes) was loading the showdesktop plug-in before unityshell, which prevented it from working with Unity.
Currently it is prohibited to start this plug-in together with Unity (so it is either showdesktop or unityshell).

Solution:
We have to make sure that showdesktop is loaded after unityshell to allow the user to use it's functionality.
The fix should involve the possibility to enable this plug-in in CCSM together with Unity and to ensure that the plug-in is loaded after unityshell.

The "Fade to Desktop" plug-in provides essentially the same functionality like already provided by unityshell (fade to desktop), the only difference is that you can adjust the fade time with it.
Unfortunately this plug-in still makes some troubles, like a popping fade-out, so it will be best to not change current behaviour and prohibit the user using it together with Unity.

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) wrote :
Revision history for this message
Omer Akram (om26er) wrote :

WFM

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Works for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/fadedesktop/fadedesktop.xml.in'
2--- plugins/fadedesktop/fadedesktop.xml.in 2012-10-15 10:31:51 +0000
3+++ plugins/fadedesktop/fadedesktop.xml.in 2012-10-16 22:23:59 +0000
4@@ -18,6 +18,7 @@
5 </relation>
6 </deps>
7 <feature>showdesktop</feature>
8+ <feature>fadetodesktop</feature>
9 <options>
10 <option name="fadetime" type="int">
11 <_short>Fade Time</_short>
12
13=== modified file 'plugins/showdesktop/showdesktop.xml.in'
14--- plugins/showdesktop/showdesktop.xml.in 2012-10-15 10:31:51 +0000
15+++ plugins/showdesktop/showdesktop.xml.in 2012-10-16 22:23:59 +0000
16@@ -14,6 +14,7 @@
17 <plugin>opengl</plugin>
18 <plugin>fade</plugin>
19 <plugin>decor</plugin>
20+ <plugin>unityshell</plugin>
21 </relation>
22 </deps>
23 <options>

Subscribers

People subscribed via source and target branches