Merge lp:~mc-return/compiz/compiz.merge-fix1048267-showmouse-does-not-work.1 into lp:compiz/0.9.9

Proposed by MC Return
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3536
Merged at revision: 3543
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix1048267-showmouse-does-not-work.1
Merge into: lp:compiz/0.9.9
Diff against target: 22 lines (+4/-1)
1 file modified
plugins/showmouse/src/showmouse.cpp (+4/-1)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix1048267-showmouse-does-not-work.1
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+141879@code.launchpad.net

Commit message

Added missing glEnable/glDisableClientState calls for GL_TEXTURE_COORD_ARRAY and GL_VERTEX_ARRAY to make showmouse work with the new codebase.

Credits and thanks for this patch go to Michail Bitzes.

(LP: #1048267)

Description of the change

> Nice, thanks. Please fix these though:
>
> 1. Separate typo fixes into a separate proposal. They are not related to the
> bug in question.

Ack. Here is proposal 1.

> 2. When you bzr commit remember --author "Michail Bitzes" to retain an
> accurate history. If there are previous revisions authored by other people
> such as yourself then the final merge will show multiple authors (which is
> probably correct).

Done here. Ack for the future.

Once this branch is merged, work will continue on this branch: https://code.launchpad.net/~mc-return/compiz/compiz.merge-fix1048267-showmouse-does-not-work/+merge/141444

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Works for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/showmouse/src/showmouse.cpp'
2--- plugins/showmouse/src/showmouse.cpp 2012-12-01 17:46:23 +0000
3+++ plugins/showmouse/src/showmouse.cpp 2013-01-04 10:18:22 +0000
4@@ -262,7 +262,8 @@
5 }
6 }
7 }
8-
9+ glEnableClientState (GL_VERTEX_ARRAY);
10+ glEnableClientState (GL_TEXTURE_COORD_ARRAY);
11 glEnableClientState (GL_COLOR_ARRAY);
12
13 glTexCoordPointer (2, GL_FLOAT, 2 * sizeof (GLfloat), coords_cache.cache);
14@@ -283,6 +284,8 @@
15 glColorPointer (4, GL_FLOAT, 4 * sizeof (GLfloat), colors_cache.cache);
16 glDrawArrays (GL_QUADS, 0, numActive);
17 glDisableClientState (GL_COLOR_ARRAY);
18+ glDisableClientState (GL_TEXTURE_COORD_ARRAY);
19+ glDisableClientState (GL_VERTEX_ARRAY);
20
21 glPopMatrix ();
22 glColor4usv (defaultColor);

Subscribers

People subscribed via source and target branches