lp:~mc-return/compiz/compiz.merge-firepaint-improvements

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.10 at revision 3769

PS Jenkins bot (community): Approve (continuous-integration) on 2013-07-21

Sam Spilsbury: Approve on 2013-07-15

MC Return: Needs Resubmitting on 2013-07-06

Diff: 820 lines (+200/-192)

3 files modified

plugins/firepaint/firepaint.xml.in (+31/-24)
plugins/firepaint/src/firepaint.cpp (+112/-112)
plugins/firepaint/src/firepaint.h (+57/-56)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1101512: Coverity UNINIT_CTOR - CID 12574 - plugins/firepaint/src/firepaint.cpp - in function: ParticleSystem::ParticleSystem(int) - Non-static class member "blendMode" is not initialized in this constructor nor in any functions that it calls.	Medium	Fix Released
Bug #1101580: Coverity UNINIT_CTOR - CID 12575 - plugins/firepaint/src/firepaint.cpp - in function: ParticleSystem::ParticleSystem() - Non-static class member "blendMode" is not initialized in this constructor nor in any functions that it calls.	Medium	Fix Released

Link a bug report

Related blueprints

3762. By MC Return on 2013-07-07

Fixed compilation (forgotten ;)

3761. By MC Return on 2013-07-07

Revert accidentially committed change

3760. By MC Return on 2013-07-07

Introduced
float fireLife = optionGetFireLife ();,
float fireWidth = optionGetFireSize ();,
float fireHeight = fireWidth * 1.5f; and
bool mystFire = optionGetFireMystical ();
and used those variables inside the loop

3759. By MC Return on 2013-07-06

Initialize all class member variables in the ParticleSystem::
ParticleSystem () ctor (LP: #1101512)
Minor indentation fixes
Renamed blend variables
Added comment and TODO

3758. By MC Return on 2013-07-04

Firepaint now has 2 tabs, 'General' and 'Particle Settings'

3757. By MC Return on 2013-07-04

Changed bg_brightness type to float, removed redundant cast, added
<precision> of 5.0 and improved tooltip

3756. By MC Return on 2013-07-04

firepaint.xml.in, improvements:
The name of this plugin is Firepaint, <short> should not contain the
description
Uppercase option titles
Punctuation for tooltips
Improved tooltips

3755. By MC Return on 2013-07-04

Fixed indentation
GL_BLEND improvements

3754. By MC Return on 2013-07-04

Firepaint, multiple improvements
(please see main commit message for details)

3753. By MC Return on 2013-07-02

CCSM:
Fixed vertical alignment of the text on the stylized keys.
(Shift, Super, Ctrl, Alt)

(LP: #1196345). Fixes: https://bugs.launchpad.net/bugs/1196345.

Approved by Brandon Schaefer, PS Jenkins bot.