Merge lp:~mc-return/compiz/compiz.merge-expo-gl-filter-improvements into lp:compiz/0.9.10

Proposed by MC Return
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3749
Merged at revision: 3750
Proposed branch: lp:~mc-return/compiz/compiz.merge-expo-gl-filter-improvements
Merge into: lp:compiz/0.9.10
Diff against target: 33 lines (+2/-11)
1 file modified
plugins/expo/src/expo.cpp (+2/-11)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-expo-gl-filter-improvements
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Sam Spilsbury Approve
Review via email: mp+172073@code.launchpad.net

Commit message

Expo:
Simplified the GL filter handling.

Description of the change

As promised, improved the filter handling for Expo as well. :)

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/expo/src/expo.cpp'
2--- plugins/expo/src/expo.cpp 2013-06-16 12:21:33 +0000
3+++ plugins/expo/src/expo.cpp 2013-06-28 15:25:29 +0000
4@@ -856,17 +856,10 @@
5 rotation = 10.0 * expoCam;
6 }
7
8- bool filterChanged = false;
9- GLenum oldFilter;
10+ GLenum oldFilter = gScreen->textureFilter ();
11
12 if (optionGetMipmaps ())
13- {
14- /* check the actual filtering */
15- oldFilter = gScreen->textureFilter ();
16-
17 gScreen->setTextureFilter (GL_LINEAR_MIPMAP_LINEAR);
18- filterChanged = true;
19- }
20
21 /* ALL TRANSFORMATION ARE EXECUTED FROM BOTTOM TO TOP */
22
23@@ -1216,9 +1209,7 @@
24
25 gScreen->glPaintTransformedOutputSetCurrentIndex (glPaintTransformedOutputIndex);
26
27- /* we just need to change the global filter state if we manipulated it before */
28- if (filterChanged)
29- gScreen->setTextureFilter (oldFilter);
30+ gScreen->setTextureFilter (oldFilter);
31 }
32
33 bool

Subscribers

People subscribed via source and target branches

to all changes: