lp:~mc-return/compiz/compiz.merge-expo-code-cleanup

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.10 at revision 3740

PS Jenkins bot (community): Approve (continuous-integration) on 2013-06-18

Sam Spilsbury: Approve on 2013-06-18

Sami Jaktholm (community): Approve on 2013-06-16

MC Return: Needs Resubmitting on 2013-06-16

Diff: 2153 lines (+653/-578)

7 files modified

plugins/expo/src/click_threshold/include/click-threshold.h (+4/-2)
plugins/expo/src/click_threshold/src/click-threshold.cpp (+5/-3)
plugins/expo/src/expo.cpp (+429/-410)
plugins/expo/src/expo.h (+105/-70)
plugins/expo/src/glow.cpp (+100/-86)
plugins/expo/src/glow.h (+6/-3)
plugins/expo/src/wall_offset/src/wall-offset.cpp (+4/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1009592: Expo Plugin: Multi-Monitor Behavior: Appearance -> Multi Output Mode "One big wall" selectable, but ignored without explanation if displays use different resolutions

Low

Fix Released

Link a bug report

Related blueprints

3717. By MC Return on 2013-06-16

Used static_cast <> (type) instead of (type) cast for all casts.

3716. By MC Return on 2013-06-16

Removed additional alignment whitespaces between if and bracket
Used static_cast <> (type) instead of (type) cast
Added whitespace between CompPoint and bracket
Removed alignment in void ExpoScreen::updateWraps (bool enable)
Try harder not to break the 80 characters limit
No need to check if (oldFilter != GL_LINEAR_MIPMAP_LINEAR) as the
setTextureFilter function is smart enough
Use w->geometry ().widthIncBorders () and w->geometry ().heightIncBorders ()
to determine winRealWidth and winRealHeight
More verbose variable names:
mpi->degToRad
scw, sw ->screenWidth
sws->screenWidthSquared
rs->curveDistSquaredPlusQuarter
pcd->pOne2MinusCurveDist
vzs->v0Squared
vts->v2Squared

3715. By MC Return on 2013-06-13

GL_FILTER change improvements

3714. By MC Return on 2013-06-13

Improved speed and indentation fixes

3713. By MC Return on 2013-06-13

Reverted the accidentially committed change to glowSize

3712. By MC Return on 2013-06-13

Improved glow texture calculations

3711. By MC Return on 2013-06-12

Simplified calculations:
-5.5f * 2 = -11.0f

No need to calculate M_PI / 180.0f 720 times
Calculate this value once instead and save it in const float mpi, use mpi
in the following looped calculations

3710. By MC Return on 2013-06-12

Merged latest lp:compiz

3709. By MC Return on 2013-05-31

Just disable GL_BLEND if it was disabled before
Added comments

3708. By MC Return on 2013-05-31

Merged latest lp:compiz