Merge lp:~mc-return/compiz/compiz.merge-enable-thumbnail-for-GL-builds into lp:compiz/0.9.9
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Daniel van Vugt | ||||
Approved revision: | 3537 | ||||
Merged at revision: | 3554 | ||||
Proposed branch: | lp:~mc-return/compiz/compiz.merge-enable-thumbnail-for-GL-builds | ||||
Merge into: | lp:compiz/0.9.9 | ||||
Diff against target: |
60 lines (+5/-2) 3 files modified
debian/compiz-plugins.install (+1/-0) plugins/CMakeLists.txt (+2/-2) plugins/thumbnail/src/thumbnail.cpp (+2/-0) |
||||
To merge this branch: | bzr merge lp:~mc-return/compiz/compiz.merge-enable-thumbnail-for-GL-builds | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
MC Return | Needs Resubmitting | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+141554@code.launchpad.net |
Commit message
Reintroduce the thumbnail (Window previews) plugin.
Just prevent building of thumbnail for GLES. It compiles and works for GL.
(LP: #1020825)
Also fixed transparency issues with glow and window-
adding calls to enable/disable GL_BLEND.
Description of the change
Note, there are a few remaining issues with this plugin:
1. Although the damage rectangle seems to be calculated correctly, sometimes
still minor flickering occurs, reminds me of the problem seen in the work-
spacenames plugin (just flickers sometimes when fully visible, never during
fade in/out).
2. The text is rendered without background and there is a rectangle behind
the text, which is fully transparent and cuts a visual hole into the glow or
background. Not 100% sure where this transparent rectangle comes from yet.
3. The .xml.in file needs cleanup and some love, some tooltips are incorrect,
others offer poor explanations. The style is generally inconsistent.
4. Thumbnail live window previews on icon mouseover are just shown for one
icon if multiple docks are loaded (like Unity Launcher + Docky).
Which of the docks shows the window preview seems to depend on chance.
I already got some solutions on my local branch to fix some of the problems above,
but do not want to mix everything up in just one MP, so this is ready for review.
The "minor transparency problem" might be fixable by increasing the damage region around the thumbnail. Can you look into this?