lp:~mc-return/compiz/compiz.merge-cube-speed-improvements

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.10 at revision 3776

Sam Spilsbury: Approve on 2013-07-22

PS Jenkins bot (community): Approve (continuous-integration) on 2013-07-21

MC Return: Needs Resubmitting on 2013-07-21

Diff: 808 lines (+200/-178)

1 file modified

plugins/cube/src/cube.cpp (+200/-178)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1101422: Coverity FORWARD_NULL - CID 12453 - plugins/cube/src/cube.cpp - deref_constant_null in function PrivateCubeScreen::PrivateCubeScreen(CompScreen *)	High	Fix Released
Bug #1101541: Coverity DIVIDE_BY_ZERO - CID 12435 - plugins/cube/src/cube.cpp - in function: PrivateCubeScreen::updateGeometry(int, int) - Several divisions by expression "sides" which may be zero has undefined behavior. Note: screen->vpSize ().width () will always return a value >= 1.	Low	Fix Released
Bug #1101575: Coverity UNINIT_CTOR - CID 12570 - plugins/cube/src/cube.cpp - in function: PrivateCubeScreen::PrivateCubeScreen(CompScreen *) - Non-static class members "mXRotations", "mCapsPainted" and "mToOpacity" are not initialized in this constructor nor in any functions that it calls.	Medium	Fix Released

Link a bug report

Related blueprints

3750. By MC Return on 2013-07-21

Merged latest lp:compiz

3749. By MC Return on 2013-07-21

Fixed style problems (over-alignment)

3748. By MC Return on 2013-07-07

Initialize all class member variables in the PrivateCubeScreen::
PrivateCubeScreen (CompScreen *) constructor
(mTc, mNOutput, mOutput, mOutputMask, mCleared, mCapsPainted)
(LP: #1101575)

3747. By MC Return on 2013-07-07

Return false in function PrivateCubeScreen::updateGeometry (int, int)
if sides should ever be 0, which should never happen, but makes Coverity
happy
(LP: #1101541)

3746. By MC Return on 2013-06-28

Simplified the GL filter handling and removed whitespace alignments

3745. By MC Return on 2013-06-20

Merged latest lp:compiz

3744. By MC Return on 2013-06-20

Improved filter handling, removed unnecessary if condition check
Minor indentation fix

3743. By MC Return on 2013-06-16

Improved variable names

3742. By MC Return on 2013-06-15

Introduced the GLfloats mSkyWidth and mSkyHeight and use those in the
following loops instead of calling mSkySize.width () and mSkySize.height ()
multiple times

3741. By MC Return on 2013-06-15

Introduced the GLfloat hInvert = 0.5f * invert; and used this variable
instead of recalculating this value multiple times