lp:~mc-return/compiz/compiz.merge-animation-code-cleanup

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.11 at revision 3781

Sami Jaktholm (community): Approve on 2013-07-25

PS Jenkins bot (community): Approve (continuous-integration) on 2013-07-24

Compiz Maintainers: Pending requested 2013-07-24

Diff: 5739 lines (+1325/-1054)

18 files modified

plugins/animation/src/animation.cpp (+440/-329)
plugins/animation/src/curvedfold.cpp (+18/-20)
plugins/animation/src/dodge.cpp (+95/-67)
plugins/animation/src/dream.cpp (+10/-11)
plugins/animation/src/extensionplugin.cpp (+81/-53)
plugins/animation/src/fade.cpp (+4/-5)
plugins/animation/src/focusfade.cpp (+8/-7)
plugins/animation/src/glide.cpp (+11/-11)
plugins/animation/src/grid.cpp (+41/-46)
plugins/animation/src/horizontalfold.cpp (+17/-21)
plugins/animation/src/magiclamp.cpp (+48/-57)
plugins/animation/src/options.cpp (+147/-116)
plugins/animation/src/private.h (+284/-205)
plugins/animation/src/restack.cpp (+52/-35)
plugins/animation/src/rollup.cpp (+10/-12)
plugins/animation/src/transform.cpp (+6/-7)
plugins/animation/src/wave.cpp (+9/-9)
plugins/animation/src/zoomside.cpp (+44/-43)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1101618: Coverity UNINIT_CTOR - CID 12566 - plugins/animation/src/grid.cpp - in function: GridAnim::GridAnim(CompWindow *, WindowEvent, float, AnimEffectInfo *, const CompRect &) - Non-static class members "mGridWidth" and "mGridHeight" are not initialized in this constructor nor in any functions that it calls.

Medium

Fix Released

Link a bug report

Related blueprints

3726. By MC Return on 2013-07-24

Fixed bug #1101618 UNINIT_CTOR

3725. By MC Return on 2013-07-21

Re-added lost ANIMATION_ABI

3724. By MC Return on 2013-07-21

Merged latest lp:compiz

3723. By MC Return on 2013-07-03

Merged latest lp:compiz

3722. By MC Return on 2013-07-03

Declare variables outside the loop
Fixed multiple style problems

3721. By MC Return on 2013-05-31

Merged latest lp:compiz

3720. By MC Return on 2013-05-19

Minor additional indentation fixes

3719. By MC Return on 2013-05-19

Animation code cleanup (please see main commit message for details)

3718. By MC Return on 2013-05-18

ccp code cleanup:

Declare variables if you need them, do not declare them if you return.
Declare CCSSettingValue *val; outside the foreach loop.
Use prefix instead of postfix increments.
Merged if condition checks.
Declaration and assignment of variables in one line.
Removed redundant brackets.
Added and removed newlines.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.

3717. By MC Return on 2013-05-18

Text plugin code cleanup:

Do not declare variables you do not need if you return anyway.
Use prefix instead of postfix increments.
Merged if condition checks.
Declaration and assignment of variables in one line.
Added and removed newlines.
Removed redundant brackets.
Fixed indentation.

Approved by PS Jenkins bot, Sam Spilsbury.