Merge lp:~mbruzek/charms/trusty/mongodb/00-setup into lp:charms/trusty/mongodb

Proposed by Matt Bruzek
Status: Merged
Merged at revision: 57
Proposed branch: lp:~mbruzek/charms/trusty/mongodb/00-setup
Merge into: lp:charms/trusty/mongodb
Diff against target: 1 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~mbruzek/charms/trusty/mongodb/00-setup
Reviewer Review Type Date Requested Status
José Antonio Rey (community) Approve
Cory Johns (community) Approve
Review via email: mp+235809@code.launchpad.net

Description of the change

The testing tool "juju test" fails to run in mongodb because the 00-setup test file is not executable and is never run.

The following tests fail because some python package is not installed.

This merge proposal fixes the problem for trusty.

To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_lint_check #805 trusty-mongodb for mbruzek mp235809
    LINT FAIL: lint-check missing

LINT Results not found.
Build: http://10.98.191.181:8080/job/charm_lint_check/805/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

UOSCI bot says:
charm_unit_test #613 trusty-mongodb for mbruzek mp235809
    UNIT FAIL: unit-test missing

UNIT Results not found.
Build: http://10.98.191.181:8080/job/charm_unit_test/613/

Revision history for this message
Cory Johns (johnsca) wrote :

The missing "lint" and "unit-test" make targets that the UOSCI bot noted notwithstanding, this change is straightforward enough and gets my +1.

review: Approve
Revision history for this message
José Antonio Rey (jose) wrote :

+1 LGTM!

Thanks, Matt!

review: Approve
Revision history for this message
Matt Bruzek (mbruzek) wrote :

Thanks for the review

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/00-setup' (properties changed: -x to +x)

Subscribers

People subscribed via source and target branches