Code review comment for lp:~mbruzek/charms/precise/memcached/trunk

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM, with one minor fix below

https://codereview.appspot.com/55950045/diff/40001/tests/10_deploy_test.py
File tests/10_deploy_test.py (right):

https://codereview.appspot.com/55950045/diff/40001/tests/10_deploy_test.py#newcode62
tests/10_deploy_test.py:62: port_string =
memcached_unit.info['open-ports'][0]
It'd be better to use configuration['tcp-port'] for this, instead of
querying the unit.info data.

https://codereview.appspot.com/55950045/

« Back to merge proposal