Code review comment for lp:~mbruzek/charms/precise/memcached/trunk

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

This looks good as a test, needs some additional robustness, see inline
comments

https://codereview.appspot.com/55950045/diff/20001/tests/10_deploy_test.py
File tests/10_deploy_test.py (right):

https://codereview.appspot.com/55950045/diff/20001/tests/10_deploy_test.py#newcode96
tests/10_deploy_test.py:96: except:
It would be nice if you used

except Exception as e:

which would allow you to use the e to detail which of the areas failed
in the test. So for your message you could add a third option, str(e) to
get the message of the error which caused the exception. This should
help show authors why the charm is failing if it fails

https://codereview.appspot.com/55950045/diff/20001/tests/10_deploy_test.py#newcode133
tests/10_deploy_test.py:133: relation = mediawiki_unit.relation('cache',
'memcached:cache')
The cache relation for memcache sends host, port, and udp-port with the
last two being configurable. You should set these to non-standard ports
in the initial configuration and test that the values are sent on the
wire properly.

https://codereview.appspot.com/55950045/

« Back to merge proposal