Code review comment for lp:~mbruzek/charms/precise/memcached/trunk

Revision history for this message
Charles Butler (lazypower) wrote :

Matt, Thank you for your work on this charm test suite, it looks
comprehensive enough to be comfortable, the only issue I found was in
the setup script there were missing dependencies.

Correct those issues and you get a +1 from me
File tests/ (right):
tests/ sudo apt-get install -y amulet
This is missing python3, and any associated python3 libraries to
complete the test run. The assumption is we are running this test on a
machine with nothing more than juju-core on it.
File tests/ (right):
tests/ try:
I like how you did this test. +1
tests/ message = 'The memcached charm passed the
deply tests!'
Typo on Deploy

« Back to merge proposal