Code review comment for lp:~mbruzek/charms/precise/memcached/trunk

Revision history for this message
Charles Butler (lazypower) wrote :

Matt, Thank you for your work on this charm test suite, it looks
comprehensive enough to be comfortable, the only issue I found was in
the setup script there were missing dependencies.

Correct those issues and you get a +1 from me

https://codereview.appspot.com/55950045/diff/1/tests/00_setup.sh
File tests/00_setup.sh (right):

https://codereview.appspot.com/55950045/diff/1/tests/00_setup.sh#newcode13
tests/00_setup.sh:13: sudo apt-get install -y amulet
This is missing python3, and any associated python3 libraries to
complete the test run. The assumption is we are running this test on a
machine with nothing more than juju-core on it.

https://codereview.appspot.com/55950045/diff/1/tests/10_deploy_test.py
File tests/10_deploy_test.py (right):

https://codereview.appspot.com/55950045/diff/1/tests/10_deploy_test.py#newcode65
tests/10_deploy_test.py:65: try:
I like how you did this test. +1

https://codereview.appspot.com/55950045/diff/1/tests/10_deploy_test.py#newcode137
tests/10_deploy_test.py:137: message = 'The memcached charm passed the
deply tests!'
Typo on Deploy

https://codereview.appspot.com/55950045/

« Back to merge proposal