OpenShot Video Library | libopenshot

Merge lp:~mbranton/libopenshot/int64_fixes into lp:libopenshot/0.0

  1. int64_fixes
  2. Merge into trunk
Proposed by matt
Status: Needs review
Proposed branch: lp:~mbranton/libopenshot/int64_fixes
Merge into: lp:libopenshot/0.0
Diff against target: 73 lines (+8/-8)
4 files modified
include/AudioReaderSource.h (+4/-4)
include/FFmpegWriter.h (+2/-2)
include/Frame.h (+1/-1)
src/Color.cpp (+1/-1)
To merge this branch: bzr merge lp:~mbranton/libopenshot/int64_fixes
Reviewer Review Type Date Requested Status
OpenShot Code Pending
Review via email: mp+308589@code.launchpad.net

Description of the change

I have namespace collisions with int64 definitions in libopenshot, this prefixes such definitions to refer to the global namespace definition.

To post a comment you must log in.

Unmerged revisions

562. By Matt Branton <email address hidden>

int64 is ambiguous when trying to add certain external dependencies to libopenshot

561. By Matt Branton <email address hidden>

Set color format so that alpha can be preserved on flood fills

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/AudioReaderSource.h'
2--- include/AudioReaderSource.h 2015-02-05 05:56:43 +0000
3+++ include/AudioReaderSource.h 2016-10-16 19:11:23 +0000
4@@ -61,8 +61,8 @@
5 int speed; /// The speed and direction to playback a reader (1=normal, 2=fast, 3=faster, -1=rewind, etc...)
6
7 ReaderBase *reader; /// The reader to pull samples from
8- int64 original_frame_number; /// The current frame to read from
9- int64 frame_number; /// The current frame number
10+ ::int64 original_frame_number; /// The current frame to read from
11+ ::int64 frame_number; /// The current frame number
12 tr1::shared_ptr<Frame> frame; /// The current frame object that is being read
13 int frame_position; /// The position of the current frame's buffer
14 double estimated_frame; /// The estimated frame position of the currently playing buffer
15@@ -80,7 +80,7 @@
16 /// @param audio_reader This reader provides constant samples from a ReaderBase derived class
17 /// @param starting_frame_number This is the frame number to start reading samples from the reader.
18 /// @param buffer_size The max number of samples to keep in the buffer at one time.
19- AudioReaderSource(ReaderBase *audio_reader, int64 starting_frame_number, int buffer_size);
20+ AudioReaderSource(ReaderBase *audio_reader, ::int64 starting_frame_number, int buffer_size);
21
22 /// Destructor
23 ~AudioReaderSource();
24@@ -134,7 +134,7 @@
25 ReaderBase* Reader() const { return reader; }
26
27 /// Seek to a specific frame
28- void Seek(int64 new_position) { frame_number = new_position; estimated_frame = new_position; }
29+ void Seek(::int64 new_position) { frame_number = new_position; estimated_frame = new_position; }
30
31 };
32
33
34=== modified file 'include/FFmpegWriter.h'
35--- include/FFmpegWriter.h 2016-09-01 04:57:06 +0000
36+++ include/FFmpegWriter.h 2016-10-16 19:11:23 +0000
37@@ -147,8 +147,8 @@
38 int cache_size;
39 bool is_writing;
40 bool is_open;
41- int64 write_video_count;
42- int64 write_audio_count;
43+ ::int64 write_video_count;
44+ ::int64 write_audio_count;
45
46 bool prepare_streams;
47 bool write_header;
48
49=== modified file 'include/Frame.h'
50--- include/Frame.h 2016-09-09 03:33:09 +0000
51+++ include/Frame.h 2016-10-16 19:11:23 +0000
52@@ -226,7 +226,7 @@
53 juce::AudioSampleBuffer *GetAudioSampleBuffer();
54
55 /// Get the size in bytes of this frame (rough estimate)
56- int64 GetBytes();
57+ ::int64 GetBytes();
58
59 /// Get pointer to Qt QImage image object
60 tr1::shared_ptr<QImage> GetImage();
61
62=== modified file 'src/Color.cpp'
63--- src/Color.cpp 2015-10-01 23:51:59 +0000
64+++ src/Color.cpp 2016-10-16 19:11:23 +0000
65@@ -68,7 +68,7 @@
66 int b = blue.GetInt(frame_number);
67 int a = alpha.GetInt(frame_number);
68
69- return QColor( r,g,b,a ).name().toStdString();
70+ return QColor( r,g,b,a ).name(QColor::HexArgb).toStdString();
71 }
72
73 // Get the distance between 2 RGB pairs (alpha is ignored)

Subscribers

People subscribed via source and target branches