Merge lp:~mbp/ubuntu/oneiric/gnupg2/815190-assertion into lp:ubuntu/oneiric/gnupg2

Proposed by Martin Pool
Status: Merged
Merge reported by: Dave Walker
Merged at revision: not available
Proposed branch: lp:~mbp/ubuntu/oneiric/gnupg2/815190-assertion
Merge into: lp:ubuntu/oneiric/gnupg2
Diff against target: 74 lines (+54/-0)
3 files modified
debian/changelog (+11/-0)
debian/patches/gnupg2-fix-libgcrypt.diff (+42/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~mbp/ubuntu/oneiric/gnupg2/815190-assertion
Reviewer Review Type Date Requested Status
Dave Walker (community) Approve
Ubuntu branches Pending
Review via email: mp+71140@code.launchpad.net

Description of the change

This takes a patch from upstream, identified by Anders Kaseorg, to fix an assertion warning that makes gpg intermittently(?) fail in Oneiric.

There is a test package of this in

https://launchpad.net/~mbp/+archive/ppa/

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Could you update the changelog to mention "upload to test ppa"? is Dave going to sponsor the upload?

Revision history for this message
Dave Walker (davewalker) wrote :

Apologies for the delay. I backed out the last commit and uploaded, Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-05-25 14:27:35 +0000
3+++ debian/changelog 2011-08-11 03:27:30 +0000
4@@ -1,3 +1,14 @@
5+gnupg2 (2.0.17-2ubuntu2) oneiric; urgency=low
6+
7+ [ Anders Kaseorg ]
8+ * debian/patches/gnupg2-fix-libgcrypt.diff: Fix assertion failure with
9+ libgcrypt 1.5.0. (LP: #815190)
10+
11+ [ Martin Pool ]
12+ * Upload to test PPA.
13+
14+ -- Martin Pool <mbp@canonical.com> Thu, 11 Aug 2011 12:57:11 +1000
15+
16 gnupg2 (2.0.17-2ubuntu1) oneiric; urgency=low
17
18 * Merge from debian unstable. Remaining changes:
19
20=== added file 'debian/patches/gnupg2-fix-libgcrypt.diff'
21--- debian/patches/gnupg2-fix-libgcrypt.diff 1970-01-01 00:00:00 +0000
22+++ debian/patches/gnupg2-fix-libgcrypt.diff 2011-08-11 03:27:30 +0000
23@@ -0,0 +1,42 @@
24+From: Werner Koch <wk@gnupg.org>
25+Subject: [PATCH] Fix a for a bug fix in the latest Libgcrypt.
26+
27+ * pkglue.c (mpi_from_sexp, pk_decrypt): Use GCRYMPI_FMT_USG for
28+ gcry_sexp_nth_mpi. This fixes a problem with a recent bug fix in
29+ Libgcrypt.
30+
31+Origin: upstream, http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commitdiff;h=13290b0e0fcf3a493e4848b29329d56b69bc4dd9
32+Last-Update: 2011-07-23
33+---
34+ g10/pkglue.c | 6 +-
35+ 1 files changed, 3 insertions(+), 3 deletions(-)
36+
37+diff --git a/g10/pkglue.c b/g10/pkglue.c
38+index cbfe21e..5c47511 100644
39+--- a/g10/pkglue.c
40++++ b/g10/pkglue.c
41+@@ -34,10 +34,10 @@ mpi_from_sexp (gcry_sexp_t sexp, const char * item)
42+ {
43+ gcry_sexp_t list;
44+ gcry_mpi_t data;
45+-
46++
47+ list = gcry_sexp_find_token (sexp, item, 0);
48+ assert (list);
49+- data = gcry_sexp_nth_mpi (list, 1, 0);
50++ data = gcry_sexp_nth_mpi (list, 1, GCRYMPI_FMT_USG);
51+ assert (data);
52+ gcry_sexp_release (list);
53+ return data;
54+@@ -293,7 +293,7 @@ pk_decrypt (int algo, gcry_mpi_t * result, gcry_mpi_t * data,
55+ if (rc)
56+ return rc;
57+
58+- *result = gcry_sexp_nth_mpi (s_plain, 0, 0);
59++ *result = gcry_sexp_nth_mpi (s_plain, 0, GCRYMPI_FMT_USG);
60+ gcry_sexp_release (s_plain);
61+ if (!*result)
62+ return -1; /* oops */
63+--
64+1.7.1
65+
66
67=== modified file 'debian/patches/series'
68--- debian/patches/series 2011-05-25 14:27:35 +0000
69+++ debian/patches/series 2011-08-11 03:27:30 +0000
70@@ -1,3 +1,4 @@
71 01-gnupg2-rename.diff
72 debian-changes-2.0.17-2
73 debian-changes-2.0.17-2ubuntu1
74+gnupg2-fix-libgcrypt.diff

Subscribers

People subscribed via source and target branches

to all changes: