Merge lp:~mbp/launchpad/use-txfixtures into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14263 |
Proposed branch: | lp:~mbp/launchpad/use-txfixtures |
Merge into: | lp:launchpad |
Prerequisite: | lp:~mbp/launchpad/800295-buildd-split |
Diff against target: |
249 lines (+16/-133) 5 files modified
lib/canonical/buildd/tests/harness.py (+4/-5) lib/canonical/launchpad/daemons/tachandler.py (+9/-127) lib/canonical/launchpad/daemons/tests/test_tachandler.py (+1/-1) setup.py (+1/-0) versions.cfg (+1/-0) |
To merge this branch: | bzr merge lp:~mbp/launchpad/use-txfixtures |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+81243@code.launchpad.net |
Commit message
[r=bac][no-qa] split out and depend upon txfixtures
Description of the change
This builds on <https:/
The only remaining code dependency of the buildds is that they need a test fixture to run a Twisted application out-of-process. I have extracted out that code into lp:txfixtures.
This patch then:
* makes Launchpad depend on txfixtures
* makes txfixtures.
* corrects in passing a test that counts on raising a DeprecationWarning for what's actually an operational warning (stale pid file) and that can be flaky on pythons where that is automatically suppressed
* changes the buildd code to use txfixtures directly rather than canonical.
I thought about changing buildd to use only relative imports so that it obviously didn't use anything from the rest of the tree and it could be more easily moved, but in the light of <https:/
This doesn't actually move the buildd out of tree but that should now be a small step.
I've left most of the tac fixture tests in the tree - they are somewhat redundant with tests now done inside txfixtures, but they're cheap and I think the integration testing is worthwhile, at least for now.
Launchpad's TacTestSetup could probably be slimmed down a bit more or even deleted entirely.
At least one more thing is needed before this can land: package txfixtures
and make that a dpkg dependency of buildd.