Launchpad itself

Merge lp:~mbp/launchpad/mail-scope into lp:launchpad

  1. mail-scope
  2. Merge into devel
Proposed by Martin Pool
Status: Rejected
Rejected by: Martin Pool
Proposed branch: lp:~mbp/launchpad/mail-scope
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/services/features/scopes.py (+1/-1)
To merge this branch: bzr merge lp:~mbp/launchpad/mail-scope
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+70095@code.launchpad.net

Commit message

[bug=810290] [r=mbp] [trivial] Escape characters in the mail_header feature scope doc string need to be escaped or they mess up the +feature-info display.

Description of the change

Escape characters in the mail_header feature scope doc string need to be escaped or they mess up the +feature-info display.

To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

this was a tweak to code that was later reverted <https://lists.launchpad.net/launchpad-dev/msg07709.html> so i'm going to cancel

Unmerged revisions

12946. By Martin Pool

Correct the docstring for mail_header

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/services/features/scopes.py'
2--- lib/lp/services/features/scopes.py 2011-05-27 23:24:02 +0000
3+++ lib/lp/services/features/scopes.py 2011-08-02 00:49:24 +0000
4@@ -184,7 +184,7 @@
5 start.
6
7 Headers are not unfolded before matching, so wrapped lines may appear as
8- "\n\t".
9+ "\\n\\t" or similar.
10 """
11
12 pattern = r'mail_header:(?P<header_name>[^:]*):(?P<value_regex>.*)'