Merge lp:~mbp/launchpad/get-the-code into lp:launchpad

Proposed by Martin Pool
Status: Merged
Approved by: j.c.sackett
Approved revision: no longer in the source branch.
Merged at revision: 14077
Proposed branch: lp:~mbp/launchpad/get-the-code
Merge into: lp:launchpad
Diff against target: 60 lines (+9/-5)
3 files modified
lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt (+2/-2)
lib/lp/app/browser/tests/base-layout.txt (+2/-1)
lib/lp/app/templates/base-layout-macros.pt (+5/-2)
To merge this branch: bzr merge lp:~mbp/launchpad/get-the-code
Reviewer Review Type Date Requested Status
j.c.sackett (community) Approve
Review via email: mp+77496@code.launchpad.net

Commit message

[r=jcsackett][no-qa] from the page footer, link to dev.launchpad.net rather than loggerhead, and link to the blog

Description of the change

It's great that Launchpad's code is open and can be changed by anyone.

If someone is interested in contributing, they probably want to start by reading dev.launchpad.net not just jumping into the loggerhead view of Launchpad, which isn't so useful without reading the instructions.

I think this deserves a majuscule and exclamation mark.

To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

discussing this on irc, perhaps I will try to also unify the two clashing footers and to also add a link to the blog. but this would probably be worth landing even as it is.

Revision history for this message
j.c.sackett (jcsackett) wrote :

I concur with your sentiment, and think this is good to land.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt'
2--- lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt 2010-10-26 01:26:00 +0000
3+++ lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt 2011-09-30 00:55:30 +0000
4@@ -51,7 +51,7 @@
5 <style...url(/@@/demo)...</style>
6 ...
7 >>> print extract_text(find_tag_by_id(browser.contents, 'lp-version'))
8- &bull; r... devmode demo site (get the code)
9+ &bull; r... devmode demo site (Get the code!)
10
11 >>> print extract_text(find_tags_by_class(
12 ... browser.contents, 'sitemessage')[0])
13@@ -70,6 +70,6 @@
14
15 >>> browser.open('http://launchpad.dev/ubuntu')
16 >>> print extract_text(find_tag_by_id(browser.contents, 'lp-version'))
17- &bull; r... devmode (get the code)
18+ &bull; r... devmode (Get the code!)
19 >>> len(find_tags_by_class(browser.contents, 'sitemessage'))
20 0
21
22=== modified file 'lib/lp/app/browser/tests/base-layout.txt'
23--- lib/lp/app/browser/tests/base-layout.txt 2011-08-30 23:30:01 +0000
24+++ lib/lp/app/browser/tests/base-layout.txt 2011-09-30 00:55:30 +0000
25@@ -173,8 +173,9 @@
26 Canonical&nbsp;Ltd. http://canonical.com/
27 Terms of use http://launchpad.dev/legal
28 Contact Launchpad Support /feedback
29+ Blog http://blog.launchpad.net/
30 System status http://identi.ca/launchpadstatus
31- get the code https://code.launchpad.net/~launchpad-pqm/launchpad/stable/
32+ Get the code! https://dev.launchpad.net/
33
34
35 Page registering
36
37=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
38--- lib/lp/app/templates/base-layout-macros.pt 2011-09-27 17:27:43 +0000
39+++ lib/lp/app/templates/base-layout-macros.pt 2011-09-30 00:55:30 +0000
40@@ -262,6 +262,9 @@
41 <a tal:condition="view/user|nothing"
42 href="/support">Contact Launchpad Support</a>
43 &nbsp;&bull;&nbsp;
44+ <a href="http://blog.launchpad.net/"
45+ >Blog</a>
46+ &nbsp;&bull;&nbsp;
47 <a href="http://identi.ca/launchpadstatus"
48 >System status</a>
49 <span id="lp-version">
50@@ -269,8 +272,8 @@
51 r<tal:revno replace="revno" />
52 <tal:devmode condition="devmode">devmode</tal:devmode>
53 <tal:demo condition="is_demo">demo site</tal:demo>
54- (<a href="https://code.launchpad.net/~launchpad-pqm/launchpad/stable/"
55- >get the code</a>)
56+ (<a href="https://dev.launchpad.net/"
57+ >Get the code!</a>)
58 </span>
59 </div>
60 </div>