Launchpad itself

Merge lp:~mbp/launchpad/721166-test-gc-warnings into lp:launchpad

  1. 721166-test-gc-warnings
  2. Merge into devel
Proposed by Martin Pool
Status: Superseded
Proposed branch: lp:~mbp/launchpad/721166-test-gc-warnings
Merge into: lp:launchpad
Diff against target: 1 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~mbp/launchpad/721166-test-gc-warnings
Reviewer Review Type Date Requested Status
Henning Eggers (community) Approve
Review via email: mp+69040@code.launchpad.net

This proposal has been superseded by a proposal from 2011-07-27.

Commit message

[r=henninge][bug=721166] [no-qa] now that bzr doesn't emit gc warning cruft, some Launchpad tests can be reenabled.

Description of the change

Per discussion in bug 721166: now that bzr doesn't emit gc warning cruft, some Launchpad tests can be reenabled.

(I don't know if they're especially important tests, but it is a critical bug, so nice to close it off.)

To post a comment you must log in.
Revision history for this message
Henning Eggers (henninge) wrote :

Thanks for doing this. I can confirm that the test now passes even after repeating it 20 times.

review: Approve
Revision history for this message
Martin Pool (mbp) wrote :

This passed locally for me and for Henning, but failed in ec2, I guess because our local copies are actually loading bzr 2.4, but official Launchpad does not have that yet, and that's where the fix for bug 791612 was landed. So this should be possible to fix once https://code.launchpad.net/~jelmer/launchpad/bzr-2.4b4/+merge/68830 is merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'lib/lp/scripts/tests/disabled_test_sphinxdocs.py' => 'lib/lp/scripts/tests/test_sphinxdocs.py'