Merge lp:~mbp/launchpad/676825-not-recently-changed into lp:launchpad

[Martin Pool]

[r=sinzui][bug=676825] Sort order is called 'not recently modified' not 'most neglected'

This has another go at bug 676825, so that sorting bugs with the least recently changed bugs first will be shown as "not recently changed."

I know this is a bit bikesheddy but calling them "neglected" really irks me, partly because it plays into a misconception that developers are being mean or lazy by not fixing every bug immediately.

You could pedantically argue that on a newly created project it will show bugs possibly still changed recently in absolute terms, but it's the best wording we could think of so far.

It also puts it below "recently changed" which I think is generally what you want.

screenshot https://bugs.launchpad.net/launchpad/+bug/676825/+attachment/2185308/+files/notrecently

[Curtis Hovey (sinzui)]

Thank you very much

review: Approve (code)

=== modified file 'lib/lp/bugs/stories/bugtask-searches/xx-sort-orders.txt'
--- lib/lp/bugs/stories/bugtask-searches/xx-sort-orders.txt	2011-06-27 15:14:46 +0000
+++ lib/lp/bugs/stories/bugtask-searches/xx-sort-orders.txt	2011-07-01 21:09:57 +0000
@@ -59,10 +59,10 @@
     1 Firefox does not support SVG
     mozilla-firefox Low Confirmed
 
-By most neglected:
+By not recently changed:
 
     >>> anon_browser.getControl(name="orderby").displayValue = [
-    ...     "most neglected"]
+    ...     "not recently changed"]
     >>> anon_browser.getControl('Search', index=0).click()
     >>> print_bugtasks(anon_browser.contents)
     1 Firefox does not support SVG

=== modified file 'lib/lp/bugs/templates/bugtarget-macros-search.pt'
--- lib/lp/bugs/templates/bugtarget-macros-search.pt	2011-06-27 14:41:18 +0000
+++ lib/lp/bugs/templates/bugtarget-macros-search.pt	2011-07-01 21:09:57 +0000
@@ -51,14 +51,14 @@
       tal:attributes="selected python:orderby == '-datecreated'"
     >newest first</option>
     <option
-      value="date_last_updated"
-      tal:attributes="selected python:orderby == 'date_last_updated'"
-    >most neglected</option>
-    <option
       value="-date_last_updated"
       tal:attributes="selected python:orderby == '-date_last_updated'"
     >most recently changed</option>
     <option
+      value="date_last_updated"
+      tal:attributes="selected python:orderby == 'date_last_updated'"
+    >not recently changed</option>
+    <option
       value="-number_of_duplicates"
       tal:attributes="selected python:orderby == '-number_of_duplicates'"
     >by number of duplicates</option>