Kanban

Merge lp:~mbp/kanban/718564-edge into lp:~jkakar/kanban/trunk

  1. 718564-edge
  2. Merge into trunk
Proposed by Martin Pool
Status: Merged
Merged at revision: 20
Proposed branch: lp:~mbp/kanban/718564-edge
Merge into: lp:~jkakar/kanban/trunk
Diff against target: 17 lines (+5/-1)
1 file modified
kanban/launchpad.py (+5/-1)
To merge this branch: bzr merge lp:~mbp/kanban/718564-edge
Reviewer Review Type Date Requested Status
Jamu Kakar Pending
Review via email: mp+49598@code.launchpad.net

Description of the change

Per http://blog.launchpad.net/general/edge-is-deprecated kanban should be updated to use LPNET_SERVICE_ROOT instead of edge. This has the annoying complication that there is no symbolic name for it except in very recent lplibs and a kludgy workaround is needed.

I tested this on maverick; it needs testing on natty.

To post a comment you must log in.
lp:~mbp/kanban/718564-edge updated
20. By Martin Pool

Merged 718564-edge [a=mbp] [r=jkakar] [f=718564]

The 'lpnet' API endpoint for Launchpad is used instead of the now
deprecated 'edge' one. This change is compatible with older releases
of launchpadlib.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'kanban/launchpad.py'
2--- kanban/launchpad.py 2011-02-06 20:18:05 +0000
3+++ kanban/launchpad.py 2011-02-14 07:31:24 +0000
4@@ -15,8 +15,12 @@
5
6 from kanban.milestone import Bug
7
8+try:
9+ from launchpadlib.launchpad import LPNET_SERVICE_ROOT
10+except ImportError, e:
11+ LPNET_SERVICE_ROOT = EDGE_SERVICE_ROOT.replace('.edge', '')
12
13-SERVICE_ROOT = EDGE_SERVICE_ROOT
14+SERVICE_ROOT = LPNET_SERVICE_ROOT
15
16
17 def _make_path(path):

Subscribers

People subscribed via source and target branches

to all changes: