Code review comment for lp:~mbp/bzr/deprecation-old

John A Meinel (jameinel) wrote :

This seems okay, though I wonder if you deleted too many tests.

Usually when we deprecate something, we keep it under test, and add a "callDeprecated" or "applyDeprecated" wrap around its call. Which ensures that
1) it is still properly deprecated
2) And it still works the way it used to, until it is removed

Deleting the tests of things that were already deprecated is, of course, fine.

Anyway, just take another quick look and see if you really wanted to delete all of TestProgressTypes, and if so, go ahead and merge.

review: Approve

« Back to merge proposal