Merge lp:~mbp/bzr/513432-fetch into lp:bzr

Proposed by Martin Pool on 2010-01-29
Status: Merged
Approved by: John A Meinel on 2010-01-29
Approved revision: 4990
Merged at revision: not available
Proposed branch: lp:~mbp/bzr/513432-fetch
Merge into: lp:bzr
Diff against target: 28 lines (+6/-1)
2 files modified
NEWS (+3/-0)
bzrlib/fetch.py (+3/-1)
To merge this branch: bzr merge lp:~mbp/bzr/513432-fetch
Reviewer Review Type Date Requested Status
John A Meinel 2010-01-29 Approve on 2010-01-29
Review via email: mp+18277@code.launchpad.net
To post a comment you must log in.
Martin Pool (mbp) wrote :

silly old jam :-)

indicates a hole in test coverage but trivial enough to land now imo.

lp:~mbp/bzr/513432-fetch updated on 2010-01-29
4990. By Martin Pool on 2010-01-29

Even trivial fixes can have silly typos

John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/513432-fetch into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #513432 AttributeError: 'Inter1and2Helper' object has no attribute 'source_repo'
> https://bugs.launchpad.net/bugs/513432
>
>
> silly old jam :-)
>
> indicates a hole in test coverage but trivial enough to land now imo.
>

I absolutely remember running into this, and I would have sworn that I
sent in a fix after the original patch landed. But, the bug is obviously
there and this is correct...

 merge: approve

Approved for the 2.1.0 branch.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktjNGAACgkQJdeBCYSNAAO0GwCdGcm+HjzmUuz8DRnYiy6Rj0yf
UnkAoNMRKNVWYOnXesRWAziJXl1rkuJC
=h4MX
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2010-01-29 11:09:30 +0000
3+++ NEWS 2010-01-29 19:04:15 +0000
4@@ -20,6 +20,9 @@
5 Bug Fixes
6 *********
7
8+* Fix "AttributeError in Inter1and2Helper" during fetch.
9+ (Martin Pool, #513432)
10+
11 Improvements
12 ************
13
14
15=== modified file 'bzrlib/fetch.py'
16--- bzrlib/fetch.py 2009-12-01 22:34:04 +0000
17+++ bzrlib/fetch.py 2010-01-29 19:04:15 +0000
18@@ -254,7 +254,9 @@
19 root_id_order.sort(key=operator.itemgetter(0))
20 # Create a record stream containing the roots to create.
21 if len(revs) > 100:
22- graph = _get_rich_root_heads_graph(self.source_repo, revs)
23+ # XXX: not covered by tests, should have a flag to always run
24+ # this. -- mbp 20100129
25+ graph = _get_rich_root_heads_graph(self.source, revs)
26 new_roots_stream = _new_root_data_stream(
27 root_id_order, rev_id_to_root_id, parent_map, self.source, graph)
28 return [('texts', new_roots_stream)]