Code review comment for lp:~mbp/bzr/192859-2.0-symlinks

Revision history for this message
John A Meinel (jameinel) wrote :

My only comment is that the tests for "tree.smart_add(['tree/a/file'])", etc, don't actually assert the state of the final tree. Just that tree.smart_add() doesn't fail.

Which I think does prove that bug 192859 is fixed, but it would be more useful as an ongoing test to not just assert that the functions don't fail with an exception, but that they did have the expected effect (the tree now sees a dir, etc.)

review: Needs Fixing

« Back to merge proposal