Merge lp:~mblayman/entertainer/preview-problem into lp:entertainer
Proposed by
Matt Layman
Status: | Merged |
---|---|
Approved by: | Matt Layman |
Approved revision: | 360 |
Merged at revision: | not available |
Proposed branch: | lp:~mblayman/entertainer/preview-problem |
Merge into: | lp:entertainer |
Diff against target: | None lines |
To merge this branch: | bzr merge lp:~mblayman/entertainer/preview-problem |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jamie Bennett (community) | Approve | ||
Samuel Buffet (community) | Approve | ||
Review via email: mp+5325@code.launchpad.net |
Commit message
The main menu now keeps focus appropriately for left and right directions and all previews now fade in. (Matt Layman)
To post a comment you must log in.
I was reviewing Samuel's branch on the main menu focus issue (Bug 357056) and thought the problem was bigger than branch submitted. I decided to hack on it because my brain was having some trouble spelling out the problems with the branch (aside from how to break the patch).
I was left with two results:
1) A fix for the problem that doesn't break. Samuel, it turns out you just had the item.get_name() check in the wrong if statement.
2) The preview menu code on the main screen has been cleaned up quite a bit. Now the preview will fade in for either the RSS or the Now Playing preview.
A note on the second point. I changed some method names because they were fairly deceptive. I changed the "show_playing_ preview" and "show_rss_preview" because they weren't really showing those previews. They actually recreate the menus and display them again. I changed "show" to "_create" so that it's clear what they are doing. Maybe someone will want to change them in the future to save calls to the feed library or prevent recreating a video texture, but it will at least be clear what they'll have to change.
In summary, I probably went way overboard to fix the bug in the branch that I was supposed to be reviewing for Samuel, but I think that the result is quite nice anyway.