Merge lp:~maxolasersquad/ubuntu/precise/stellarium/add_quicklist into lp:ubuntu/precise/stellarium

[David Baucum]

Adds a Unity Quicklist shortcut to Stellarium's launcher.

[Bogdan Marinov (daggerstab)]

The added menu options are puzzling. In what use case the user would like to select a landscape before Stellarium runs?

I think that there are only two command-line options that make sense to be called by menus: an option to run Stellarium in a window (because it is launched in full screen by default) and the --safe-mode (no OpenGL2 mode) option that fixes some problems with graphics on some systems.

[David Baucum (maxolasersquad)]

Ok, I'll modify it this afternoon to have those two options.

[lp:~maxolasersquad/ubuntu/precise/stellarium/add_quicklist]

14. By David Baucum on 2012-02-24

Changed quicklist to only offer fullscreen and windowed modes.

[David Baucum (maxolasersquad)]

The latest commit has the options you suggested. When stellarium is opened in window-mode then it default to always opening in a window so I created an option for both fullscreen and window.

[lp:~maxolasersquad/ubuntu/precise/stellarium/add_quicklist]

15. By David Baucum on 2012-02-24

Added a safe mode option to the quicklist.

[Michael Hall (mhall119)]

Thanks so much for your submission!

Unfortunately your submission is for a package that can only be translated by the upstream developers, so you will need to send your changes to them first. If they are accepted by the upstream project, they will then be included in the next release of Ubuntu.

Recently a new FreeDesktop.org specification[1] has been approved for providing desktop-agnostic shortcuts. The Quicklist documentation has been updated to coincide with this new spec[2].

Since this is now an official standard, and will benefit environments other than Unity, we encourage you to change your code to match. This will require the following changes:
1) Change "X-Ayatana-Desktop-Shortcuts" to just "Actions"
2) Change each section from "[<action> Shortcut Group]" to "[Desktop Action <action>]"
3) Remove "TargetEnvironment=Unity"
4) Change your Name= entry to use Title Case[3] (capitalizing important words)

Please make these changes and submit them to the upstream projects so they can be included in future versions of project and future releases of Ubuntu.

[1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s08.html
[2] https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists
[3] http://en.wikipedia.org/wiki/Title_case#Headings_and_publication_titles

review: Needs Fixing

Unmerged revisions

15. By David Baucum on 2012-02-24

Added a safe mode option to the quicklist.

14. By David Baucum on 2012-02-24

Changed quicklist to only offer fullscreen and windowed modes.

13. By David Baucum on 2012-02-23

Add a Unity Quicklist

=== modified file 'data/stellarium.desktop'
--- data/stellarium.desktop	2010-07-31 15:44:02 +0000
+++ data/stellarium.desktop	2012-02-24 03:42:17 +0000
@@ -7,3 +7,21 @@
 Icon=stellarium
 X-Icon-path=/usr/share/icons/
 X-Window-Icon=stellarium
+
+X-Ayatana-Desktop-Shortcuts=Screen;Window
+
+[Window Group]
+Name=Open in window
+Exec=stellarium -f no
+TargetEnvironment=Unity
+
+[Fullscreen Group]
+Name=Open in fullscreen
+Exec=stellarium -f yes
+TargetEnvironment=Unity
+
+[Safemode Group]
+Name=Open in safe mode
+Exec=stellarium --safe-mode
+TargetEnvironment=Unity
+