Merge lp:~maxolasersquad/ubuntu/precise/filezilla/add_quicklist into lp:ubuntu/precise/filezilla

Proposed by David Baucum
Status: Work in progress
Proposed branch: lp:~maxolasersquad/ubuntu/precise/filezilla/add_quicklist
Merge into: lp:ubuntu/precise/filezilla
Diff against target: 12 lines (+5/-0)
1 file modified
data/filezilla.desktop (+5/-0)
To merge this branch: bzr merge lp:~maxolasersquad/ubuntu/precise/filezilla/add_quicklist
Reviewer Review Type Date Requested Status
Michael Hall (community) Needs Fixing
Sebastien Bacher Needs Fixing
Ubuntu branches Pending
Review via email: mp+94309@code.launchpad.net

Description of the change

Adds a Unity Quicklist shortcut to Filezilla's launcher.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, could you send it upstream

We can't translate universe sources easily and it's late in the cycle so better to get that upstream first

I'm setting the merge request to "in progress" to get it out of the sponsoring queue for now since we will not upload it before precise

Note that to be consistent with other entries you might want to use the "Open Site Manager" wording

review: Needs Fixing
Revision history for this message
Michael Hall (mhall119) wrote :

Thanks so much for your submission!

Unfortunately your submission is for a package that can only be translated by the upstream developers, so you will need to send your changes to them first. If they are accepted by the upstream project, they will then be included in the next release of Ubuntu.

Recently a new FreeDesktop.org specification[1] has been approved for providing desktop-agnostic shortcuts. The Quicklist documentation has been updated to coincide with this new spec[2].

Since this is now an official standard, and will benefit environments other than Unity, we encourage you to change your code to match. This will require the following changes:
1) Change "X-Ayatana-Desktop-Shortcuts" to just "Actions"
2) Change each section from "[<action> Shortcut Group]" to "[Desktop Action <action>]"
3) Remove "TargetEnvironment=Unity"
4) Change your Name= entry to use Title Case[3] (capitalizing important words)

Please make these changes and submit them to the upstream projects so they can be included in future versions of project and future releases of Ubuntu.

[1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s08.html
[2] https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists
[3] http://en.wikipedia.org/wiki/Title_case#Headings_and_publication_titles

review: Needs Fixing

Unmerged revisions

41. By David Baucum

Add a Unity Quicklist

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/filezilla.desktop'
2--- data/filezilla.desktop 2012-01-29 23:11:01 +0000
3+++ data/filezilla.desktop 2012-02-23 03:31:18 +0000
4@@ -12,3 +12,8 @@
5 Type=Application
6 Categories=Network;FileTransfer;
7 Version=1.0
8+
9+X-Ayatana-Desktop-Shortcuts=Screen;Window
10+name=Open the site manager
11+Exec=filezilla -s
12+TargetEnvironment=Unity

Subscribers

People subscribed via source and target branches

to all changes: